Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix write-back commits #767

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

jannfis
Copy link
Contributor

@jannfis jannfis commented Jul 4, 2024

Fixes #754

Actually, gpg binary was missing from Dockerfile too.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (ae3eec3) to head (412225c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files          31       31           
  Lines        3117     3117           
=======================================
  Hits         1924     1924           
  Misses       1049     1049           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannfis jannfis changed the title fix: Fix non-signed commits fix: Fix write-back commits Jul 4, 2024
@chengfang chengfang merged commit 7f93ac5 into argoproj-labs:master Jul 5, 2024
10 checks passed
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: repocreds do not GitHub App credentials
3 participants