-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): add unit tests for cmd/template.go, cmd/util.go and cmd/version.go #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Mangaal
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
July 2, 2024 09:36
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
+ Coverage 59.98% 61.82% +1.83%
==========================================
Files 31 31
Lines 3109 3112 +3
==========================================
+ Hits 1865 1924 +59
+ Misses 1100 1044 -56
Partials 144 144 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mangaal <[email protected]>
jannfis
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
LGTM.
jannfis
changed the title
add unit tests for cmd/template.go, cmd/util.go and cmd/version.go
chore(tests): add unit tests for cmd/template.go, cmd/util.go and cmd/version.go
Jul 2, 2024
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…/version.go (argoproj-labs#765) Signed-off-by: Mangaal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for cmd/template.go, cmd/util.go and cmd/version.go.
Changes Made
log.Fatalf
withfmt.Fprintf
for printing errors tocmd.ErrOrStderr()
.fmt.Printf
withfmt.Fprintf
for printing output tocmd.OutOrStdout()
.Reason for Changes
The previous implementation used
log.Fatalf
andfmt.Printf
, which made it difficult to capture the command output in unit tests. By usingfmt.Fprintf
withcmd.ErrOrStderr()
andcmd.OutOrStdout()
, the output can be directed to buffers, allowing the unit test to capture and verify the output effectively.