chore: Update feature flag name for infinite scroll functionality#39876
chore: Update feature flag name for infinite scroll functionality#39876rahulbarwal merged 4 commits intoreleasefrom
Conversation
WalkthroughThis pull request updates the name of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
...t/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts
Outdated
Show resolved
Hide resolved
…o rahulbarwal/update-infinite-scroll-flag-name
…psmithorg#39876) ## Description The feature flag was incorrectly named, and that flag key cannot be changed directly in Launch. To address this, I will update the flag name in the code itself instead of creating an additional flag. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14122296394> > Commit: d298c96 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14122296394&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Fri, 28 Mar 2025 05:36:33 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the feature flag for infinite scroll behavior on release tables to enhance clarity and consistency in naming. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
The feature flag was incorrectly named, and that flag key cannot be changed directly in Launch. To address this, I will update the flag name in the code itself instead of creating an additional flag.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Table"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14122296394
Commit: d298c96
Cypress dashboard.
Tags:
@tag.TableSpec:
Fri, 28 Mar 2025 05:36:33 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit