Skip to content

chore: Update feature flag name for infinite scroll functionality#39876

Merged
rahulbarwal merged 4 commits intoreleasefrom
rahulbarwal/update-infinite-scroll-flag-name
Mar 28, 2025
Merged

chore: Update feature flag name for infinite scroll functionality#39876
rahulbarwal merged 4 commits intoreleasefrom
rahulbarwal/update-infinite-scroll-flag-name

Conversation

@rahulbarwal
Copy link
Contributor

@rahulbarwal rahulbarwal commented Mar 24, 2025

Description

The feature flag was incorrectly named, and that flag key cannot be changed directly in Launch. To address this, I will update the flag name in the code itself instead of creating an additional flag.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14122296394
Commit: d298c96
Cypress dashboard.
Tags: @tag.Table
Spec:


Fri, 28 Mar 2025 05:36:33 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Updated the feature flag for infinite scroll behavior on release tables to enhance clarity and consistency in naming.

@rahulbarwal rahulbarwal added the Table Widget V2 Issues related to Table Widget V2 label Mar 24, 2025
@rahulbarwal rahulbarwal self-assigned this Mar 24, 2025
@rahulbarwal rahulbarwal added the Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE label Mar 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2025

Walkthrough

This pull request updates the name of the release_tablev2_infinitescroll_enabled feature flag to release_table_infinitescroll_enabled in the FeatureFlag.ts file, ensuring consistency in naming conventions. Corresponding changes are made in the test suite and constants to reflect this new flag name. The values associated with the flags remain unchanged, and no other functionalities are affected.

Changes

File Change Summary
app/client/src/ce/entities/FeatureFlag.ts Renamed release_tablev2_infinitescroll_enabled to release_table_infinitescroll_enabled in both FEATURE_FLAG and DEFAULT_FEATURE_FLAG_VALUE.
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts Updated the argument in featureFlagIntercept from release_tablev2_infinitescroll_enabled: true to release_table_infinitescroll_enabled: true.
app/client/src/widgets/TableWidgetV2/constants.ts Changed INFINITE_SCROLL_ENABLED to reference FEATURE_FLAG["release_table_infinitescroll_enabled"] instead of FEATURE_FLAG["release_tablev2_infinitescroll_enabled"].

Possibly related PRs

Suggested labels

Enhancement, Widgets Product

Suggested reviewers

  • AmanAgarwal041
  • jacquesikot
  • sneha122

Poem

A little tweak in our feature flag's tune,
A string rewritten beneath the code's moon.
Small in change but clear in sight,
Guiding our flags with renewed light.
Happy code dancing in digital delight!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between d5066aa and d298c96.

📒 Files selected for processing (1)
  • app/client/src/ce/entities/FeatureFlag.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/ce/entities/FeatureFlag.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahulbarwal rahulbarwal added the ok-to-test Required label for CI label Mar 24, 2025
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 24, 2025
@rahulbarwal rahulbarwal requested review from a team and ApekshaBhosale as code owners March 24, 2025 08:25
@rahulbarwal rahulbarwal requested review from jacquesikot and removed request for a team March 24, 2025 08:25
@rahulbarwal rahulbarwal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Mar 24, 2025
@rahulbarwal rahulbarwal merged commit 300e7d7 into release Mar 28, 2025
43 checks passed
@rahulbarwal rahulbarwal deleted the rahulbarwal/update-infinite-scroll-flag-name branch March 28, 2025 07:43
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
…psmithorg#39876)

## Description
The feature flag was incorrectly named, and that flag key cannot be
changed directly in Launch. To address this, I will update the flag name
in the code itself instead of creating an additional flag.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Table"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14122296394>
> Commit: d298c96
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14122296394&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`
> Spec:
> <hr>Fri, 28 Mar 2025 05:36:33 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated the feature flag for infinite scroll behavior on release
tables to enhance clarity and consistency in naming.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE skip-changelog Adding this label to a PR prevents it from being listed in the changelog Table Widget V2 Issues related to Table Widget V2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants