chore: Fix failing spec with updated string#33378
Conversation
WalkthroughWalkthroughThe update involves a refinement in a Cypress test file within a client application. A new import statement has been added to include Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js (1)
30-32: The updated element selector usingcreateMessageenhances maintainability and localization. However, consider using a more specific selector thanspanto improve test reliability.
Description
Since
ab_show_templates_instead_of_blank_canvas_enabledflag is GA, we removed its ref from code and updated empty canvas to have a differnt layout.Updated the spec to reflect that.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9061366694
Commit: ea00dcc
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?