Skip to content

chore: Fix failing spec with updated string#33378

Merged
rahulbarwal merged 5 commits intoreleasefrom
chore-fix-page-pad-spec
May 13, 2024
Merged

chore: Fix failing spec with updated string#33378
rahulbarwal merged 5 commits intoreleasefrom
chore-fix-page-pad-spec

Conversation

@rahulbarwal
Copy link
Contributor

@rahulbarwal rahulbarwal commented May 13, 2024

Description

Since ab_show_templates_instead_of_blank_canvas_enabled flag is GA, we removed its ref from code and updated empty canvas to have a differnt layout.

Updated the spec to reflect that.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9061366694
Commit: ea00dcc
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 13, 2024

Walkthrough

Walkthrough

The update involves a refinement in a Cypress test file within a client application. A new import statement has been added to include createMessage utility function and a constant STARTER_TEMPLATE_PAGE_LAYOUTS from a common constants module. This change likely improves error handling or messaging capabilities in the application's test suite. Moreover, an element selector in a test has been adjusted for better test accuracy.

Changes

File Path Change Summary
.../cypress/e2e/Regression/ClientSide/.../Page_Load_Spec.js Added imports for createMessage and STARTER_TEMPLATE_PAGE_LAYOUTS from .../src/ce/constants/messages. Changed element selector from cy.get("h2").contains("Drag and drop a widget here") to cy.get("span").contains("Choose a template").

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d3f8d5f and ea00dcc.
Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js (2 hunks)
Additional comments not posted (1)
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js (1)

13-16: Import statement for createMessage and STARTER_TEMPLATE_PAGE_LAYOUTS looks correct and aligns with previous review comments.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahulbarwal rahulbarwal self-assigned this May 13, 2024
@rahulbarwal rahulbarwal added Templates Product Issues related to Templates Templates labels May 13, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 13, 2024
@rahulbarwal rahulbarwal added the ok-to-test Required label for CI label May 13, 2024
ApekshaBhosale
ApekshaBhosale previously approved these changes May 13, 2024
@rahulbarwal rahulbarwal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 13, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js (1)

30-32: The updated element selector using createMessage enhances maintainability and localization. However, consider using a more specific selector than span to improve test reliability.

@rahulbarwal rahulbarwal merged commit 217da70 into release May 13, 2024
@rahulbarwal rahulbarwal deleted the chore-fix-page-pad-spec branch May 13, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Templates Product Issues related to Templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants