Skip to content

chore: Update feature flag name for infinite scroll functionality #39876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulbarwal merged 4 commits into from
Mar 28, 2025
+4 −5
Merged

chore: Update feature flag name for infinite scroll functionality #39876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1359a89
fix: Update feature flag name for infinite scroll functionality
rahulbarwal Mar 24, 2025
d87873b
fix: Rename feature flag for infinite scroll in table widget
rahulbarwal Mar 24, 2025
d5066aa
fix: Update feature flag naming for infinite scroll functionality
rahulbarwal Mar 24, 2025
d298c96
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ describe(
function () {
before(() => {
featureFlagIntercept({
release_tablev2_infinitescroll_enabled: true,
release_table_infinitescroll_enabled: true,
});

// Set up a table with test data
Expand Down
5 changes: 2 additions & 3 deletions app/client/src/ce/entities/FeatureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ export const FEATURE_FLAG = {
release_ads_entity_item_enabled: "release_ads_entity_item_enabled",
release_external_saas_plugins_enabled:
"release_external_saas_plugins_enabled",
release_tablev2_infinitescroll_enabled:
"release_tablev2_infinitescroll_enabled",
release_table_infinitescroll_enabled: "release_table_infinitescroll_enabled",
license_multi_org_enabled: "license_multi_org_enabled",
release_table_custom_sort_function_enabled:
"release_table_custom_sort_function_enabled",
Expand Down Expand Up @@ -101,7 +100,7 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
config_mask_session_recordings_enabled: true,
release_ads_entity_item_enabled: false,
release_external_saas_plugins_enabled: false,
release_tablev2_infinitescroll_enabled: false,
release_table_infinitescroll_enabled: false,
license_multi_org_enabled: false,
release_table_custom_sort_function_enabled: false,
};
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/widgets/TableWidgetV2/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export const ALLOW_TABLE_WIDGET_SERVER_SIDE_FILTERING =
FEATURE_FLAG["release_table_serverside_filtering_enabled"];

export const INFINITE_SCROLL_ENABLED =
FEATURE_FLAG["release_tablev2_infinitescroll_enabled"];
FEATURE_FLAG["release_table_infinitescroll_enabled"];

export const CUSTOM_SORT_FUNCTION_ENABLED =
FEATURE_FLAG["release_table_custom_sort_function_enabled"];
Loading