Conversation
…#36832) /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the `Avatar` component for displaying user avatars. - Added the `Markdown` component for rendering Markdown content with GitHub Flavored Markdown support. - Enhanced `AIChat` component with a new modular input system and improved message display. - **Bug Fixes** - Updated CSS for better styling consistency across components. - **Refactor** - Removed outdated components (`ChatDescriptionModal` and `ThreadMessage`) to streamline the codebase. - Simplified the structure of `AIChat` by incorporating new components. - **Documentation** - Updated Storybook stories for `AIChat`, `Avatar`, and `Markdown` components to showcase new features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11320929997> > Commit: db2bc5c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11320929997&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 14 Oct 2024 04:42:54 UTC <!-- end of auto-generated comment: Cypress test results -->
## Description Adds editable tab behavior for queries and JS objects. Fixes #32440 /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11288430138> > Commit: dc89acb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11288430138&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 11 Oct 2024 09:55:27 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a new dependency for improved React hooks functionality. - Added new constants for data source operations and user interactions, enhancing feedback and clarity. - **Improvements** - Enhanced messaging related to data source actions, providing clearer user prompts and error handling messages. - Renamed constants for better readability and consistency across the application. - **Bug Fixes** - Corrected naming conventions for constants to improve consistency across the application. - **Chores** - Removed deprecated `FileTabs` component and related tests to streamline the codebase. - Added unit tests for the `FileTab` component to ensure expected functionality. - Updated the `Text` component to improve ref handling and styling options. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…6851) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11321563633> > Commit: 402dfb3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11321563633&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 14 Oct 2024 06:12:25 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced user creation process with automatic generation of user management permission groups and policies. - Introduced a new method for creating permission groups associated with user management. - **Bug Fixes** - Streamlined the assignment of user policies during user creation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description PR to add the polling for `pg_isready` signal for embedded postgres DB. This will fix the infinite loop where postgres refuse to come up. We have seen this failure earlier with `openshift` setup. Current PR will make sure when the embedded postgres fails to startup we are not copying the postgres.conf file as well so supervisor won't have to start the postgres process at all. Ref: https://theappsmith.slack.com/archives/C0341RERY4R/p1728565913269689?thread_ts=1728544650.663739&cid=C0341RERY4R /test Sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11322083108> > Commit: df82790 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11322083108&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 14 Oct 2024 08:17:55 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced database initialization process with a maximum attempts mechanism for waiting on PostgreSQL to start. - Improved configuration handling for `APPSMITH_DB_URL` based on database type. - **Bug Fixes** - Ensured robust error handling if PostgreSQL fails to start within the specified attempts. - **Documentation** - Added comments for improved clarity in the deployment script. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description I deleted all the code associated with the AI chat widget from CE and moved it to EE. In order for the code splitting to work correctly, I created two empty files: - [src/ee/modules/ui-builder/ui/wds/constants.ts](https://github.com/appsmithorg/appsmith/pull/36845/files#diff-472f9e0642a7c5739f6fc585d877c3f7ead4aec2525db231f724a6a981c400fd) - [src/ee/modules/ui-builder/ui/wds/index.ts](https://github.com/appsmithorg/appsmith/pull/36845/files#diff-295de4eead00758748f21d11af43f079a635fcf3b377d428a15c6f7555e8882c) Related EE PR — appsmithorg/appsmith-ee#5333 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11324026199> > Commit: 2e41096 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11324026199&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 14 Oct 2024 10:04:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new constants and variables for enhanced widget mapping and configuration. - **Bug Fixes** - Removed outdated components and exports from the AIChat and ChatInput modules to streamline functionality. - **Chores** - Cleaned up unused files and exports to improve codebase maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Persisting latest branch. Re-opening the branch opens it in the latest branch Fixes #30321 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11325191494> > Commit: 570c6fb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11325191494&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 14 Oct 2024 10:27:07 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced Git branch management functionality in the ApplicationCard component. - New utility functions for storing and retrieving the latest Git branch. - Improved error handling and response management for Git operations. - Added user-specific tracking for Git branches in the AppEditorEngine. - Introduced a new feature flag for Git branch persistence. - New Cypress test suite to verify Git branch persistence after switching branches. - Added methods for asserting branch visibility and URL consistency in the GitSync class. - **Bug Fixes** - Refined error handling for various sagas, ensuring accurate error dispatching and user feedback. - **Documentation** - Updated function signatures and error handling descriptions in the initialization and Git synchronization processes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description I forgot to delete it in the previous issue. ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11325795465> > Commit: 6ec1c0f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11325795465&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 14 Oct 2024 11:06:16 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Removed the `ChatInput` component, which previously provided a customizable text input area with features for error handling and dynamic resizing. - **Chores** - Deleted the associated TypeScript type definitions for `ChatInputProps`, simplifying the component structure. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the workflow for the Ad-hoc Docker Image to include a new step for preparing server artifacts, enhancing the packaging process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Fix : https://github.com/appsmithorg/appsmith/security/advisories/GHSA-5f24-4j99-h3gc#event-330907 Use bash syntax to access the environment variable: $EVENT_COMMITS Fixes #`36835` ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD 18af836 yet > <hr>Mon, 14 Oct 2024 04:55:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a `run_count` input parameter for specifying the number of test repetitions. - Added input parameters for manual triggering in the CI workflow. - New environment variable `COMMIT_INFO_AUTHOR` captures the author name for better context in commit messages. - **Improvements** - Enhanced logic for handling commit messages and test run conditions. - Improved caching mechanism for better tracking of test outcomes across runs. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description This PR omits props to be sent to the DOM component as they are not required, leading to errors on development. Fixes ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11142003456> > Commit: 49353f7 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11142003456&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 02 Oct 2024 10:58:14 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced `isMultiLine` prop for enhanced multi-line input handling. - Added new customization options for buttons, including `primaryColor`, `navColorStyle`, and more. - Enhanced `IconButtonComponent` with additional props for greater flexibility. - **Bug Fixes** - Improved error handling for Google reCAPTCHA integration. - Corrected property name from `varient` to `variant` across various components to ensure consistent styling. - **Chores** - Updated component structures to ensure unique identification during rendering. - Minor typographical corrections in comments for clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11339670501> > Commit: cc4ac6d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11339670501&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 15 Oct 2024 07:53:17 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Integrated New Relic for enhanced telemetry tracking. - **Bug Fixes** - Removed the `Heartbeat` component to streamline application performance and rendering logic. - **Chores** - Cleaned up unnecessary variables related to component rendering. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description This PR includes the changes to enable browser side caching of dependency map in published mode. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11338708443> > Commit: af545a2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11338708443&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 15 Oct 2024 07:42:33 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced asynchronous profiling for web worker operations, enhancing telemetry capabilities. - Updated handling of the `EVAL_TREE` action to support asynchronous processing, improving performance. - Added a caching mechanism for computation results, optimizing data retrieval and management. - **Bug Fixes** - Improved accuracy of `applicationId` extraction for fetching published page resources. - **Tests** - Enhanced test cases for `DataTreeEvaluator` and caching mechanisms to reflect realistic application states. - **Chores** - Updated various components to support new asynchronous logic and caching properties. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
## Description This PR enables back the RedisPluginTest Junit test case. It was disabled earlier as it was failing in build promotion. I have ran the test case multiple times on local and it did not fail at all, hence enabling it back. Will run it couple of times in CI too. Fixes #36774 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11348382724> > Commit: 91dce61 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11348382724&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 15 Oct 2024 15:38:37 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enabled the `RedisPluginTest` class for execution, allowing all test methods to run and validate the Redis plugin's behavior. - **Tests** - No changes to the logic or structure of existing tests; focus remains on validating datasource configurations and command execution. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”>
…36893) ## Description Updating the permission check for run button in response pane to fix the button being disabled even though the user has execute permissions. Fixes [#36873](#36873) ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11359075861> > Commit: 4bc6d8a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11359075861&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 16 Oct 2024 05:26:33 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the `isRunDisabled` property to enhance the `QueryResponseTab` component, improving execution control based on user permissions. - Updated several components to reflect the new `isRunDisabled` prop, streamlining execution permission handling. - **Bug Fixes** - Renamed `disabled` prop to `isRunDisabled` for clarity and consistency across components. - **Documentation** - Enhanced clarity in the UI regarding execution permissions and action contexts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
/ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11362114942> > Commit: e1fc66e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11362114942&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Wed, 16 Oct 2024 09:07:10 UTC <!-- end of auto-generated comment: Cypress test results -->
## Description **Problem** A redundant evaluation cycle is run every time a user focuses on an InputWidget component and the isFocused meta state is updated **Root Cause** `isFocus` property of InputWidgetV2 is a meta property and updated through `this.updateWidgetMetaProperty`, thereby changes to these property triggers an evaluation cycle run **Solution** Implement the `isFocus` property as a local state of the InputWidgetV2 component Fixes #36446 ## Automation /ok-to-test tags="@tag.Widget, @tag.Input" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11362334893> > Commit: 80e9089 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11362334893&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Input` > Spec: > <hr>Wed, 16 Oct 2024 10:22:00 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced focus management for the InputWidget, allowing for improved internal state handling. - Multi-line text input now supports submitting with keyboard shortcuts for a more streamlined user experience. - **Bug Fixes** - Resolved issues with widget metadata by excluding the `isFocused` property from the meta properties. - Improved internal state management for input changes, reducing reliance on external properties. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Expanded automated review configuration to include "pg" and "release" branches. - **Chores** - Minor formatting adjustment in the configuration file for improved clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Added the changes from move to pg script from the postgres branch to keep in sync. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced data transformation process for improved compatibility with Postgres. - Introduced mapping for `_class` field to `type` field. - **Bug Fixes** - Improved handling of asynchronous operations during MongoDB client instantiation. - **Refactor** - Clarified condition checks in data transformation logic for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11100769096> > Commit: 46e043c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11100769096&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 30 Sep 2024 07:14:51 UTC <!-- end of auto-generated comment: Cypress test results --> /ok-to-test tags="@tag.Sanity"
## Description - Moving older components, utils and constants into the Plugin Action Editor to complete the modularisation project. - Update Plugin Action Editor to expect an action ID instead of fetching it from the URL. - Add a Readme Fixes #34324 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11363303457> > Commit: c36241f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11363303457&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 16 Oct 2024 12:40:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new utility function `formatBytes` for byte formatting. - Added comprehensive documentation for the Plugin Action Editor module. - **Improvements** - Simplified action retrieval logic in the Plugin Action Editor. - Enhanced import organization across various components for better maintainability. - **Bug Fixes** - Resolved import path issues for several components and constants to ensure correct functionality. - **Chores** - Updated multiple import paths to reflect the new directory structure for improved modularity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11370534880> > Commit: dea75ff > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11370534880&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 16 Oct 2024 17:40:56 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved handling and reporting of test failures during the build process. - Enhanced logging for better clarity on test results. - **New Features** - Introduced detailed output for failed and skipped tests, now available in the GitHub step summary and as comments on pull requests. - Added new input parameter `is-pg-build` for enhanced workflow control. - Updated default value for `skip-tests` to "false" to enforce test execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…36909) ## Description TinyMCE initially switched from LGPL to MIT in 2022, aiming for a more permissive license. However, it reverted to GPL v2+ for version 7, which is a concern for us. TinyMCE 6.8.3 under the MIT license until October 31, 2024, it will stop receiving any security updates post that. Fixes #36859 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.TextEditor" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11379278624> > Commit: 8aa96b6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11379278624&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.TextEditor` > Spec: > <hr>Thu, 17 Oct 2024 06:29:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
kamakshibhat-appsmith
requested review from
ApekshaBhosale,
sagar-qa007 and
sharat87
as code owners
kamakshibhat-appsmith
requested review from
AnaghHegde,
abhvsn,
ayushpahwa and
pratapaprasanna
as code owners
laveena-en
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?