chore: add soft token + add subtle button variant#36899
Conversation
|
Note: This PR adds a new subtle variant that we will use for suggested prompt buttons in AIChat component. |
| import type { ReactNode } from "react"; | ||
| import type { COLORS } from "../../../shared"; | ||
|
|
||
| export interface TextProps extends React.HTMLAttributes<HTMLElement> { |
There was a problem hiding this comment.
I wonder why this was removed? This change will not allow to pass standard html attributes to Text
There was a problem hiding this comment.
So what was happening was initially when creating markdown components for paragraphs, I was using ...props and passing it to our Text which resulted in type conflicts as props of paragraph were HTMLParagraphElement and our Text couldn't accept those props. So I added the above code to fix it. But later I removed ...props part. So not required anymore.
Having the above causes issues in storybook. It shows all props of HTMLelement in the docs. 🫠
There was a problem hiding this comment.
Got it, thanks. I still believe that ability to pass standard html attributes to any components is required (do you agree?). I'm sure that mentioned issues can be fixed, but don't think we have time for it. So it is up to you, feel free to resolve the thread 👍
/ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11362114942> > Commit: e1fc66e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11362114942&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Wed, 16 Oct 2024 09:07:10 UTC <!-- end of auto-generated comment: Cypress test results -->

/ok-to-test tags="@tag.Anvil"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11362114942
Commit: e1fc66e
Cypress dashboard.
Tags:
@tag.AnvilSpec:
Wed, 16 Oct 2024 09:07:10 UTC