chore: Update tinymce version to 6.8.3 in package.json and yarn.lock#36909
Merged
rahulbarwal merged 5 commits intoreleasefrom Oct 17, 2024
Merged
chore: Update tinymce version to 6.8.3 in package.json and yarn.lock#36909rahulbarwal merged 5 commits intoreleasefrom
rahulbarwal merged 5 commits intoreleasefrom
Conversation
rahulbarwal
added
the
Widgets & Accelerators Pod
github-actions
bot
added
the
skip-changelog
rahulbarwal
added
ok-to-test
github-actions
bot
added
the
skip-changelog
The code changes in this commit fix the issue with selecting the text color in the RichTextEditor. The previous code was using an incorrect selector for the text color button, causing the selection to fail. This commit updates the selector to correctly select the text color button and allows users to choose the desired color. Refactor the selector for the text color button in the RichTextEditor to use the correct attribute and value.
…o rahulbarwal/issue36859
Contributor
Author
|
/ci-test-limit-count run_count=15 |
rahulbarwal
requested review from
ApekshaBhosale,
KelvinOm and
sagar-qa007
as code owners
github-actions
bot
added
Needs Triaging
…extEditor" This reverts commit dfb7919.
jsartisan
approved these changes
Oct 17, 2024
sagar-qa007
approved these changes
Oct 17, 2024
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11379004416. |
github-actions bot
pushed a commit
to Zeral-Zhang/appsmith
that referenced
this pull request
Nov 20, 2024
…ppsmithorg#36909) ## Description TinyMCE initially switched from LGPL to MIT in 2022, aiming for a more permissive license. However, it reverted to GPL v2+ for version 7, which is a concern for us. TinyMCE 6.8.3 under the MIT license until October 31, 2024, it will stop receiving any security updates post that. Fixes appsmithorg#36859 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.TextEditor" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11379278624> > Commit: 8aa96b6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11379278624&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.TextEditor` > Spec: > <hr>Thu, 17 Oct 2024 06:29:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TinyMCE initially switched from LGPL to MIT in 2022, aiming for a more permissive license. However, it reverted to GPL v2+ for version 7, which is a concern for us.
TinyMCE 6.8.3 under the MIT license until October 31, 2024, it will stop receiving any security updates post that.
Fixes #36859
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.TextEditor"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11379278624
Commit: 8aa96b6
Cypress dashboard.
Tags:
@tag.TextEditorSpec:
Thu, 17 Oct 2024 06:29:32 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?