Skip to content

chore: Fix failing spec with updated string #33378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulbarwal merged 5 commits into from
May 13, 2024
Merged

chore: Fix failing spec with updated string #33378

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93ed230
Fixed failing spec with correct string based on the updated flags.
rahulbarwal May 13, 2024
d3f8d5f
removes unnecessary imports.
rahulbarwal May 13, 2024
292e7fa
chore: Update page load test to use starter template message constant
rahulbarwal May 13, 2024
3698bd3
fixes prettier issues
rahulbarwal May 13, 2024
ea00dcc
fixes tags
rahulbarwal May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ import {
} from "../../../../support/Objects/ObjectsCore";
import PageList from "../../../../support/Pages/PageList";
import { EntityItems } from "../../../../support/Pages/AssertHelper";
import {
createMessage,
STARTER_TEMPLATE_PAGE_LAYOUTS,
} from "../../../../../src/ce/constants/messages";

describe("Page Load tests", { tags: ["@tag.IDE"] }, () => {
describe("Page Load tests", { tags: ["@tag.IDE", "@tag.Templates"] }, () => {
afterEach(() => {
agHelper.SaveLocalStorageCache();
});
Expand All @@ -23,7 +27,9 @@ describe("Page Load tests", { tags: ["@tag.IDE"] }, () => {
before(() => {
agHelper.AddDsl("PageLoadDsl");
PageList.AddNewPage();
cy.get("h2").contains("Drag and drop a widget here");
cy.get("span").contains(
createMessage(STARTER_TEMPLATE_PAGE_LAYOUTS.header),
);
});

it("1. Published page loads correctly", () => {
Expand Down