fix: broken line in page settings #30951

rohan-arthur · 2024-02-07T08:03:52Z

Description

for old pages that were created before the new url style, the page settings has a prompt to ask the user to change the URL.
The line in this prompt is broken

This PR changes this line to:

For testing, you can get an example old app from here

PR fixes following issue(s)

Fixes #30922

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

Manual
JUnit
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Speedbreak features have been covered
Test plan covers all impacted features and areas of interest
Test plan has been peer reviewed by project stakeholders and other QA members
Manually tested functionality on DP
We had an implementation alignment call with stakeholders post QA Round 2
Cypress test cases have been added and approved by SDET/manual QA
Added Test Plan Approved label after Cypress tests were reviewed
Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

Refactor
- Updated the wording of messages related to setting page URLs for enhanced clarity and consistency.
- Changed test tags from @tag.Settings to @tag.Visual for improved test categorization.
- Modified JSEditor indentation visual tests to include additional test cases and adjustments in test descriptions.
- Updated test tags from @tag.JS to @tag.Visual for consistency in test categorization.
- Added @tag.Visual to the list of tags for test categorization.

coderabbitai · 2024-02-07T08:04:45Z

Walkthrough

The changes involve updating various tags in the visual regression tests to ensure consistency and clarity in categorization, specifically moving from @tag.Settings to @tag.Visual where applicable.

Changes

File Path	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/VisualTests/*.js`	Updated test descriptions and tags from `@tag.Settings` to `@tag.Visual` for consistency and clarity in visual regression test categorization.
`app/client/cypress/tags.js`	Added `@tag.Visual` to the list of tags in the `module.exports` object to include it in test categorization.

Assessment against linked issues

Objective	Addressed	Explanation
#30922: Fix broken line in page URL settings	❌	The changes made in the PR do not directly address the broken line issue in the page URL settings as reported in the linked issue. The focus of the changes is on updating test tags for visual regression tests, not on fixing the specific bug related to the broken line.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rohan-arthur · 2024-02-07T08:06:11Z

/build-deploy-preview skip-test=true

app/client/src/ce/constants/messages.ts

github-actions · 2024-02-07T08:06:37Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7811699655.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 30951.
recreate: .

rohan-arthur · 2024-02-07T08:06:37Z

/ok-to-test tags="@tag.Settings"

github-actions · 2024-02-07T08:07:01Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7811704870.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Settings.

github-actions · 2024-02-07T08:19:25Z

Deploy-Preview-URL: https://ce-30951.dp.appsmith.com

github-actions · 2024-02-07T08:32:53Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7811704870.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/DatasourcePageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/WidgetsLayout_spec.js

To know the list of identified flaky tests - Refer here

rohan-arthur · 2024-02-07T09:02:47Z

going to rerun failed tests because the three failures seem unrelated.

github-actions · 2024-02-07T09:10:34Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7811704870.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/DatasourcePageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/WidgetsLayout_spec.js

To know the list of identified flaky tests - Refer here

rohan-arthur · 2024-02-07T09:23:03Z

second rerun after pulling latest changes from release, as the three failures look completely unrelated.

github-actions · 2024-02-07T09:30:55Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7811704870.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/DatasourcePageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/WidgetsLayout_spec.js

To know the list of identified flaky tests - Refer here

Aishwarya-U-R · 2024-02-09T08:41:52Z

/build-deploy-preview skip-tests=true

github-actions · 2024-02-09T08:42:16Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7841565945.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 30951.
recreate: .

github-actions · 2024-02-09T08:54:59Z

Deploy-Preview-URL: https://ce-30951.dp.appsmith.com

Aishwarya-U-R · 2024-02-09T09:04:12Z

/ok-to-test tags="@tag.Settings"

github-actions · 2024-02-09T09:04:34Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7841774940.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Settings.

github-actions · 2024-02-09T09:28:32Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7841774940.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/DatasourcePageLayout_spec.js
cypress/e2e/Regression/ClientSide/VisualTests/WidgetsLayout_spec.js

To know the list of identified flaky tests - Refer here

Aishwarya-U-R · 2024-02-12T06:05:51Z

/ok-to-test tags="@tag.Settings"

github-actions · 2024-02-12T06:06:23Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7867905342.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Settings.

github-actions · 2024-02-12T06:29:38Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7867905342.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

rohan-arthur added 3 commits February 7, 2024 12:48

test commit message

967befd

fixes the broken line in page settings

459783c

adds period at end of line

53bc6d3

coderabbitai bot reviewed Feb 7, 2024

View reviewed changes

app/client/src/ce/constants/messages.ts Show resolved Hide resolved

merge latest from release

400d9d2

albinAppsmith previously approved these changes Feb 8, 2024

View reviewed changes

Merge branch 'release' into fix/30922-broken-line-page-settings

4a2b16e

VisualTests/AppPageLayout_spec.js fix

e42dde8

Aishwarya-U-R dismissed albinAppsmith’s stale review via e42dde8 February 9, 2024 09:04

DatasourcePageLayout_spec & WidgetsLayout_spec.js fix

c0607fc

Merge branch 'release' into fix/30922-broken-line-page-settings

840b373

rohan-arthur self-assigned this Feb 12, 2024

rohan-arthur requested a review from albinAppsmith February 12, 2024 06:09

albinAppsmith approved these changes Feb 12, 2024

View reviewed changes

hetunandu merged commit 4af6946 into release Feb 12, 2024
16 checks passed

hetunandu deleted the fix/30922-broken-line-page-settings branch February 12, 2024 07:42

Nikhil-Nandagopal added the IDE Product Issues related to the IDE Product label Aug 5, 2024

github-actions bot added the QA Needs QA attention label Aug 5, 2024

Nikhil-Nandagopal added Artifact Platform Product Issues related to the application platform and removed IDE Pod Issues that new developers face while exploring the IDE Artifact Platform Product Issues related to the application platform labels Aug 5, 2024

github-actions bot added the IDE Pod Issues that new developers face while exploring the IDE label Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: broken line in page settings #30951

fix: broken line in page settings #30951

rohan-arthur commented Feb 7, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 7, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

Aishwarya-U-R commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

Aishwarya-U-R commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

Aishwarya-U-R commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

fix: broken line in page settings #30951

fix: broken line in page settings #30951

Conversation

rohan-arthur commented Feb 7, 2024 • edited by coderabbitai bot Loading

Description

PR fixes following issue(s)

Media

Type of change

Testing

How Has This Been Tested?

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

QA activity:

Summary by CodeRabbit

coderabbitai bot commented Feb 7, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

rohan-arthur commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

Aishwarya-U-R commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

Aishwarya-U-R commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

github-actions bot commented Feb 9, 2024

Aishwarya-U-R commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

rohan-arthur commented Feb 7, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 7, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)