Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: broken line in page settings (#30951)
## Description for old pages that were created before the new url style, the page settings has a prompt to ask the user to change the URL. The line in this prompt is broken ![Screenshot 2024-02-06 at 14 23 12](https://github.com/appsmithorg/appsmith/assets/94514895/2feab25f-be2a-4c87-ba89-47cc9686aed2) This PR changes this line to: ![Screenshot 2024-02-06 at 14 33 41](https://github.com/appsmithorg/appsmith/assets/94514895/920a5e7d-dabd-48a0-92c4-0b079232f2dd) For testing, you can get an example old app from [here](https://theappsmith.slack.com/archives/C02JT9CSE6L/p1707204475068809?thread_ts=1706698534.445299&cid=C02JT9CSE6L) #### PR fixes following issue(s) Fixes #30922 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated the wording of messages related to setting page URLs for enhanced clarity and consistency. - Changed test tags from `@tag.Settings` to `@tag.Visual` for improved test categorization. - Modified JSEditor indentation visual tests to include additional test cases and adjustments in test descriptions. - Updated test tags from `@tag.JS` to `@tag.Visual` for consistency in test categorization. - Added `@tag.Visual` to the list of tags for test categorization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <[email protected]>
- Loading branch information