Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken line in page settings #30951

Merged
merged 8 commits into from
Feb 12, 2024
Merged

fix: broken line in page settings #30951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
967befd
test commit message
rohan-arthur Feb 7, 2024
459783c
fixes the broken line in page settings
rohan-arthur Feb 7, 2024
53bc6d3
adds period at end of line
rohan-arthur Feb 7, 2024
400d9d2
merge latest from release
rohan-arthur Feb 7, 2024
4a2b16e
Merge branch 'release' into fix/30922-broken-line-page-settings
Aishwarya-U-R Feb 9, 2024
e42dde8
VisualTests/AppPageLayout_spec.js fix
Aishwarya-U-R Feb 9, 2024
c0607fc
DatasourcePageLayout_spec & WidgetsLayout_spec.js fix
Aishwarya-U-R Feb 9, 2024
840b373
Merge branch 'release' into fix/30922-broken-line-page-settings
Aishwarya-U-R Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import homePage from "../../../../locators/HomePage";
import * as _ from "../../../../support/Objects/ObjectsCore";

describe("Visual regression tests", { tags: ["@tag.Settings"] }, () => {
describe("Visual regression tests", { tags: ["@tag.Visual"] }, () => {
// for any changes in UI, update the screenshot in snapshot folder, to do so:
// 1. Delete the required screenshot which you want to update.
// 2. Run test in headless mode with any browser
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/VisualTests/DatasourcePageLayout_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
AppSidebarButton,
} from "../../../../support/Pages/EditorNavigation";

describe("Visual tests for datasources", { tags: ["@tag.Settings"] }, () => {
describe("Visual tests for datasources", { tags: ["@tag.Visual"] }, () => {
// for any changes in UI, update the screenshot in snapshot folder, to do so:
// 1. Delete the required screenshot which you want to update.
// 2. Run test in headless mode with any browser
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/e2e/Regression/ClientSide/VisualTests/JSEditorComment_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ObjectsRegistry } from "../../../../support/Objects/Registry";
let jsEditor = ObjectsRegistry.JSEditor,
agHelper = ObjectsRegistry.AggregateHelper;

describe("JSEditor Comment - Visual tests", { tags: ["@tag.JS"] }, () => {
describe("JSEditor Comment - Visual tests", { tags: ["@tag.Visual"] }, () => {
it("1. comments code on the editor", () => {
jsEditor.CreateJSObject(
`export default {
Expand Down
Loading
Loading