Fix unregistered celery tasks - #510
Merged
Merged
Conversation
Fix Unregistered Task openedx.core.djangoapps.bookmarks.tasks.update_xblock_cache task is not getting autodiscovered by celery and needs to be imported explicitly PROD-284
openedx.core.djangoapps.ccxcon.tasks.update_ccxcon is not get auto discovered by celery. Adding it to CELERY_IMPORTS to be explicitly added. PROD-283
OmarIthawi
requested review from
iamjazzar,
johnbaldwin,
melvinsoft and
thraxil
December 30, 2019 06:06
johnbaldwin
reviewed
Dec 30, 2019
| CELERY_IMPORTS = ( | ||
| 'cms.djangoapps.contentstore.tasks', | ||
| 'openedx.core.djangoapps.bookmarks.tasks', | ||
| 'openedx.core.djangoapps.ccxcon.tasks', |
There was a problem hiding this comment.
Just to be clear: We register the tasks module here and then register the specific function within the tasks module with the @task decorator?
Author
There was a problem hiding this comment.
I guess so @johnbaldwin! I'm honestly not super sure why it's not being called but I'd like to cherry pick those issues first as they'll come from upstream later on anyway.
I think this will fix the issue. If it doesn't fix our issue, we'll use another fix like #508 later on.
johnbaldwin
approved these changes
Dec 30, 2019
thraxil
approved these changes
Dec 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by Anders in #508. Celery tasks failure is one of the most annoying noise in our logs. This should fix the issue. I've cherry picked both https://github.com/edx/edx-platform/pull/21297 and https://github.com/edx/edx-platform/pull/21305 from upstream.
Fixes RED-437.
Closes #508.