make bookmarks update_xblocks_cache task name match function - #508
Closed
thraxil wants to merge 1 commit into
Closed
make bookmarks update_xblocks_cache task name match function#508thraxil wants to merge 1 commit into
thraxil wants to merge 1 commit into
Conversation
OmarIthawi
suggested changes
Dec 30, 2019
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Thank you for jumping on this. I gotta admit we stalled it for a pretty long time.
While this might fix the error it probably won't survive the next release upgrade. Please see #510.
|
Closing in favor of #510. Thank you again Anders! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating some of the celery related sentry errors like this one: https://sentry.io/organizations/appsembler/issues/1024724752/events/61b07188c79d4a579fafc712953e3a85/?project=87786
I still don't know exactly what's causing them, but I did notice that in this case, the name assigned to the task
....update_xblock_cachedidn't match the actual function name,update_xblocks_cache(). Everywhere that it's called elsewhere in the codebase, eg here: https://github.com/appsembler/edx-platform/blob/appsembler/tahoe/master/openedx/core/djangoapps/bookmarks/signals.py#L20 it is referenced asupdate_xblocks_cache.So, I don't know if this will actually fix that error (it probably won't; there are a bunch of similar exceptions that lead me to believe it's something more related to how the celery workers are configured), but it certainly seems like it was a typo and wouldn't hurt to make it more consistent.