Fix unregistered celery task: course_structures - #541
Merged
Conversation
OmarIthawi
force-pushed
the
omar/course-task
branch
2 times, most recently
from
March 11, 2020 13:08
826c7b0 to
14ab0c6
Compare
johnbaldwin
reviewed
Mar 11, 2020
There was a problem hiding this comment.
Type "Because" and suggest "because the app will no longer exist"
johnbaldwin
approved these changes
Mar 11, 2020
johnbaldwin
left a comment
johnbaldwin
left a comment
There was a problem hiding this comment.
Just a typo in the comment string and small language suggestion
Mainly to fix KeyError exception when the task course_structures.tasks.update_course_structure is received.
OmarIthawi
force-pushed
the
omar/course-task
branch
from
March 11, 2020 13:38
14ab0c6 to
4774de8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly to fix
KeyErrorexceptions when the taskcourse_structures.tasks.update_course_structureis received.This is similar to: #510 but the
course_structuresapp is no longer there after Hawthorn, so we're not pushing this upstream.