Remove UserOrganizationMapping from common; tests for enrollment multi-tenant helpers - #1181
Merged
Conversation
OmarIthawi
requested review from
estherjsuh,
melvinsoft,
shadinaif and
thraxil
as code owners
June 29, 2022 14:22
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 2596538236
💛 - Coveralls |
OmarIthawi
changed the title
This comment has been minimized.
This comment has been minimized.
OmarIthawi
force-pushed
the
use-tahoe-sites-api-patch03
branch
from
June 29, 2022 23:04
c2e9c03 to
1ce8645
Compare
This comment has been minimized.
This comment has been minimized.
OmarIthawi
force-pushed
the
use-tahoe-sites-api-patch03
branch
from
June 29, 2022 23:19
1ce8645 to
723af98
Compare
This comment has been minimized.
This comment has been minimized.
thraxil
approved these changes
Jun 30, 2022
…by_username_or_email - Added tests for `get_user_by_username_or_email_inside_organization` - Consolidated `get_user_by_username_or_email_inside_organization` inside `get_user_by_username_or_email` - Added tests for `CourseEnrollment.enroll_by_email_in_organization` - Consolidated `CourseEnrollment.enroll_by_email_in_organization` inside `enroll_by_email` - Fixed RED-2007 and #903 - Fixed RED-2009 as well
OmarIthawi
force-pushed
the
use-tahoe-sites-api-patch03
branch
from
July 1, 2022 12:10
723af98 to
506c84f
Compare
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
|
melvinsoft
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes merge conflicts for the #1113 PR while adding needed coverage.
Closes #1113.
As a side-effect:
get_user_by_username_or_email_inside_organizationget_user_by_username_or_email_inside_organizationinsideget_user_by_username_or_emailCourseEnrollment.enroll_by_email_in_organizationCourseEnrollment.enroll_by_email_in_organizationinsideenroll_by_emailTAHOE_MULTITENANT_BULK_ENROLLMENTintoAPPSEMBLER_MULTI_TENANT_EMAILSTODO