Use tahoe-sites.api - Patch 03 - #1113
Closed
shadinaif wants to merge 2 commits into
Closed
Conversation
shadinaif
requested review from
OmarIthawi,
estherjsuh,
melvinsoft and
thraxil
as code owners
March 24, 2022 09:39
This comment has been minimized.
This comment has been minimized.
shadinaif
force-pushed
the
shadinaif/use-tahoe-sites-api-patch03
branch
from
March 24, 2022 09:59
04d9ee0 to
89ed8db
Compare
|
Checking git merge conflicts against https://github.com/edx/edx-platform.git
|
Pull Request Test Coverage Report for Build 2033534302
💛 - Coveralls |
|
@shadinaif we have many new and uncovered lines, please see the report: https://coveralls.io/builds/47650411/source?filename=common%2Fdjangoapps%2Fstudent%2Fmodels.py#L1637 |
OmarIthawi
approved these changes
Apr 5, 2022
Comment on lines
+25
to
+26
| # tahoe-sites==0.1.5 plus new APIs | ||
| -e git+https://github.com/appsembler/tahoe-sites.git@2bffb54a96b469005d5f397a400b74a8af4d05db#egg=tahoe-sites==0.1.5-newapis |
There was a problem hiding this comment.
Suggested change
| # tahoe-sites==0.1.5 plus new APIs | |
| -e git+https://github.com/appsembler/tahoe-sites.git@2bffb54a96b469005d5f397a400b74a8af4d05db#egg=tahoe-sites==0.1.5-newapis | |
| tahoe-sites==0.1.6 |
thraxil
approved these changes
Apr 14, 2022
|
Anything holding this up? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Use tahoe-sites.api - Patch 03:
Type of change
Related issues
https://appsembler.atlassian.net/browse/RED-2709
Checklists
Development
Security
Code review