Skip to content

Multitenant Emails: Add support for cohorts email assignment - #903

Closed
OmarIthawi wants to merge 2 commits into
mainfrom
omar/cohorts-mte
Closed

Multitenant Emails: Add support for cohorts email assignment#903
OmarIthawi wants to merge 2 commits into
mainfrom
omar/cohorts-mte

Conversation

@OmarIthawi

@OmarIthawi OmarIthawi commented May 6, 2021

Copy link
Copy Markdown

Jira bug: RED-2007: LMS/Instructor tab/Cohort: The Assign students to cohorts by uploading a CSV file. is not functional

TODO

  • Fix the permissions by requiring proper AMC Admin staff role
  • Make tests work
  • Fix the bug and cleanup the pull request

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 40.202% when pulling 8cf1b68fa1166ac3dca3dffcd85a63103c70fc55 on omar/cohorts-mte into 4dcb409 on main.

@OmarIthawi

Copy link
Copy Markdown
Author

Closing until we do the Juniper cutover.

@OmarIthawi OmarIthawi closed this May 26, 2021
@OmarIthawi OmarIthawi reopened this Aug 2, 2021
@OmarIthawi OmarIthawi changed the title mte: cohorts Multitenant Emails: Add support for cohorts email assignment Aug 2, 2021
@OmarIthawi
OmarIthawi requested a review from shadinaif February 5, 2022 11:52
@OmarIthawi

Copy link
Copy Markdown
Author

Closing my pull request after assigning the Jira issue to @shadinaif.

@OmarIthawi OmarIthawi closed this Feb 5, 2022
@OmarIthawi
OmarIthawi deleted the omar/cohorts-mte branch February 5, 2022 11:54
OmarIthawi added a commit that referenced this pull request Jul 1, 2022
…by_username_or_email

 - Added tests for `get_user_by_username_or_email_inside_organization`
 - Consolidated `get_user_by_username_or_email_inside_organization` inside `get_user_by_username_or_email`
 - Added tests for `CourseEnrollment.enroll_by_email_in_organization`
 - Consolidated  `CourseEnrollment.enroll_by_email_in_organization` inside `enroll_by_email`
 - Fixed RED-2007 and #903
 - Fixed RED-2009 as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants