chore: update nuget build and deploy github action to support semantic versioning 2.0 #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laolubenson
force-pushed
the
chore/578-update-nuget-release-action
branch
3 times, most recently
from
64d875b to
57f14ed
Compare
laolubenson
force-pushed
the
chore/578-update-nuget-release-action
branch
from
57f14ed to
a00d3cb
Compare
Collaborator
|
@akinsolb seems like you have a merge conflict. |
Collaborator
Author
Ah yes, this may be because another pr got merged before this. I'll fix in a moment |
Dor-bl
requested changes
Jan 10, 2023
Collaborator
Dor-bl
left a comment
Dor-bl
left a comment
There was a problem hiding this comment.
What about the net45 removal?
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;net48;net45</TargetFrameworks> |
Dor-bl
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an
xin the boxes that applyDetails
Updates the GitHub nuget build and deploy action to work with Semantic Version 2
resolves #578