Skip to content

chore: update nuget build and deploy github action to support semantic versioning 2.0 #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2023
Merged

chore: update nuget build and deploy github action to support semantic versioning 2.0 #580

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
262be68
build: re-enable GeneratePackageOnBuild for GithubAction
laolubenson Jan 14, 2021
ad30ec2
Merge branch 'master' of https://github.com/appium/appium-dotnet-driver
laolubenson Oct 14, 2022
9c2b433
Merge branch 'master' of https://github.com/appium/appium-dotnet-driver
laolubenson Jan 7, 2023
a00d3cb
chore: update nuget build and deploy github action to support semanti…
laolubenson Jan 7, 2023
ebcddad
Merge branch 'master' into chore/578-update-nuget-release-action
laolubenson Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/release-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,26 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v3
with:
dotnet-version: 3.1.101
dotnet-version: 3.1.x

- name: Install dependencies
run: dotnet restore src/Appium.Net.sln

- name: Build
run: |
if ("${{github.ref}}".trim() -notmatch '^refs/tags/v(\d+\.\d+\.\d+)$') {
exit 1
if ("${{github.ref}}".trim() -notmatch '^refs\/tags\/v(((0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*))(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)$') {
Write-Host "Failed to find a tag with a value compatible with Sementic Versioning.\nEnsure the Sementic Versioning regex above matches the tag created for the release!"; exit 1
}
$version = $matches[1]
dotnet build src/Appium.Net.sln --no-restore --configuration Release -p:Version=$version
else {
$versionPrefix = $matches[2]
$dotnetBuildCmd = "dotnet build src/Appium.Net.sln --configuration Release -p:VersionPrefix=${versionPrefix}"
if ($matches.Count -eq 7) {
$versionSuffix = $matches[6]
$dotnetBuildCmd += " --version-suffix ${versionSuffix}"
}
}
Write-Host $dotnetBuildCmd
Invoke-Expression $dotnetBuildCmd

- name: Deploy to nuget
run: dotnet nuget push **/*.nupkg --api-key ${{ secrets.NUGET_DEPLOY_KEY }} --source https://api.nuget.org/v3/index.json
7 changes: 2 additions & 5 deletions src/Appium.Net/Appium.Net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net48;net45</TargetFrameworks>
Copy link
Collaborator

@Dor-bl Dor-bl Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here
net45 target

<TargetFrameworks>netstandard2.0;net48</TargetFrameworks>
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
<RootNamespace>OpenQA.Selenium</RootNamespace>
<Company>Appium Commiters</Company>
<Product>Dotnet-Client</Product>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Copyright>Copyright © 2022</Copyright>
<Copyright>Copyright © 2023</Copyright>
<PackageProjectUrl>https://github.com/appium/dotnet-client</PackageProjectUrl>
<RepositoryUrl>https://github.com/appium/dotnet-client</RepositoryUrl>
<RepositoryType>git</RepositoryType>
Expand All @@ -32,9 +32,6 @@
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net48|AnyCPU'">
<DocumentationFile>Appium.Net.xml</DocumentationFile>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net45|AnyCPU'">
<DocumentationFile>Appium.Net.xml</DocumentationFile>
</PropertyGroup>

<ItemGroup>
<None Include="LICENSE.txt" Pack="true" PackagePath="" />
Expand Down
2 changes: 1 addition & 1 deletion test/integration/Appium.Net.Integration.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net48;net45</TargetFrameworks>
<TargetFrameworks>net48</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<Compile Remove="apps\**" />
Expand Down