feat(client): Add timeout and connect error to backoff transient error #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
requested review from
EverlastingBugstopper and
lrlna
as code owners
|
@ptondereau thanks for working on this. We're in the midst of some work on federation at the moment so I don't have time to review this right this moment but rest assured I will not forget! Thanks for your patience. |
ptondereau
commented
Mar 2, 2022
| @@ -166,6 +197,22 @@ fn handle_graphql_body_errors(errors: Vec<GraphQLError>) -> Result<(), RoverClie | |||
| } | |||
| } | |||
|
|
|||
| /// Downcasts the given err source into T. | |||
| fn get_source_error_type<T: std::error::Error + 'static>( | |||
There was a problem hiding this comment.
this hack because waiting for hyperium/hyper#2711
👷 Deploy request for apollo-cli-docs pending review.Visit the deploys page to approve it
|
EverlastingBugstopper
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
@ptondereau thanks so much for your patience on this. This looks great! We'll get it in for the next release
This was referenced Apr 5, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#790
I think I could make it, but I don't know how to test with httpmock a connect error.
I turned 400's errors into a transient error, but I could revert this, if you want.
Configuration with CLI argument should be done in another PR.
Inspiration: https://github.com/TrueLayer/reqwest-middleware/blob/main/reqwest-retry/src/retryable.rs