Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance exponential backoff retries for HTTP requests to work for connectivity issues #790

Closed
theJC opened this issue Sep 10, 2021 · 4 comments · Fixed by #1063 or #1079
Closed

Enhance exponential backoff retries for HTTP requests to work for connectivity issues #790

theJC opened this issue Sep 10, 2021 · 4 comments · Fixed by #1063 or #1079
Assignees
Labels
feature 🎉 new commands, flags, functionality, and improved error messages

Comments

@theJC
Copy link

theJC commented Sep 10, 2021

Description

In #693 HTTP retries with backoff were added, but appear to only be for when a response is received and its an internal error (based on the release notes, haven't found any other documentation yet)

Please expand this capability to retry on connection failures or timeouts.

Bonus points/stretch goal would be to add command line arguments to control the number of requests and timing of the backoff strategy used.

This will make everyone's use of rover in CICD pipelines much more hardened and less likely to fail. In our organization we typically get several messages a week in our support channels where teams have had their CICD pipeline fail on them because of rover having connect connection or timeout issues when checking our publishing their schema.

This past week, the incident: https://status.apollographql.com/incidents/4xcz62jzl7s9 was responsible for a spate of customers pipelines failing.

@theJC theJC added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Sep 10, 2021
@abernix abernix self-assigned this Oct 19, 2021
@ptondereau
Copy link
Contributor

@abernix I would like to pick the issue, but I'm seeing that you're assigned to it.
May I propose something?

@EverlastingBugstopper
Copy link
Contributor

Hey @ptondereau - we'd love your proposal! Sorry your comment was lost in the fray.

@ptondereau
Copy link
Contributor

ptondereau commented Feb 9, 2022

Hey @ptondereau - we'd love your proposal! Sorry your comment was lost in the fray.

I'm very busy since I've found a new job, but I'll try to come with a PR quickly!

@EverlastingBugstopper
Copy link
Contributor

OK! If it turns out you don't feel like working on this then don't feel any obligation to, just wanted to let you know that we'd accept a PR if you decided it was worth your time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants