Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error): add additional methods to determine kind #2711

Closed
wants to merge 1 commit into from
Closed

feat(error): add additional methods to determine kind #2711

wants to merge 1 commit into from

Conversation

omjadas
Copy link

@omjadas omjadas commented Dec 2, 2021

Add additional methods to determine error kind.

@seanmonstar
Copy link
Member

Thanks for the PR! I'm generally in favor of having accessor methods to inspect the error more. However, I've also been thinking the current Kind enum variants are a little disorganized, and have thought it may warrant an internal cleanup. Are there any variants that you specifically needed to know, or were you just wanting to add methods for all variants?

@omjadas
Copy link
Author

omjadas commented Dec 8, 2021

Thanks for the PR! I'm generally in favor of having accessor methods to inspect the error more. However, I've also been thinking the current Kind enum variants are a little disorganized, and have thought it may warrant an internal cleanup. Are there any variants that you specifically needed to know, or were you just wanting to add methods for all variants?

The ones that I am particularly interested are Io and Shutdown.

@omjadas
Copy link
Author

omjadas commented Feb 15, 2022

@seanmonstar Just coming back to this. I would be happy to update this PR to only add methods for the Io and Shutdown error kinds (assuming you are happy with those two) and potentially any others you think should be exposed as well.

@seanmonstar
Copy link
Member

We'll be going in a different direction, adding a Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants