Skip to content

fix(subscription): do not log an error when the websocket stream has been interrupted, keep it in trace level to avoid useless noises (backport #8344)#8383

Merged
bnjjj merged 1 commit into1.xfrom
mergify/bp/1.x/pr-8344
Oct 8, 2025
Merged

fix(subscription): do not log an error when the websocket stream has been interrupted, keep it in trace level to avoid useless noises (backport #8344)#8383
bnjjj merged 1 commit into1.xfrom
mergify/bp/1.x/pr-8344

Conversation

@bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Oct 7, 2025

Convert log from error level to trace when the websocket stream has been interrupted to avoid useless noises.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes


This is an automatic backport of pull request #8344 done by [Mergify](https://mergify.com).

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

…been interrupted, keep it in trace level to avoid useless noises (#8344)

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
(cherry picked from commit b0a1e90)
@mergify mergify bot assigned bnjjj Oct 7, 2025
@bnjjj bnjjj requested a review from a team October 7, 2025 21:12
@bnjjj bnjjj requested review from a team as code owners October 7, 2025 21:12
@apollo-librarian
Copy link

apollo-librarian bot commented Oct 7, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: e9032191f3d9428868a5d1b1
Build Logs: View logs

@bnjjj bnjjj requested a review from BrynCooke October 7, 2025 21:41
@bnjjj bnjjj enabled auto-merge (squash) October 8, 2025 11:55
@bnjjj bnjjj merged commit bcbefde into 1.x Oct 8, 2025
14 checks passed
@bnjjj bnjjj deleted the mergify/bp/1.x/pr-8344 branch October 8, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants