Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changesets/fix_bnjjj_fix_error_log_subs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### fix(subscription): do not log an error when the websocket stream has been interrupted, keep it in trace level to avoid useless noises ([PR #8344](https://github.com/apollographql/router/pull/8344))

Convert log from `error` level to `trace` when the websocket stream has been interrupted to avoid useless noises.

By [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/8344
2 changes: 1 addition & 1 deletion apollo-router/src/protocols/websocket.rs
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ where
}
Ok(Message::Frame(frame)) => serde_json::from_slice(frame.payload()),
Err(err) => {
tracing::error!("cannot consume more message on websocket stream: {err:?}");
tracing::trace!("cannot consume more message on websocket stream: {err:?}");

Ok(ServerMessage::Error {
id: id.to_string(),
Expand Down