Revert some IndexMap/Set changes that break --release builds for x86#5847
Merged
dylan-apollo merged 2 commits intonextfrom Aug 19, 2024
Merged
Revert some IndexMap/Set changes that break --release builds for x86#5847dylan-apollo merged 2 commits intonextfrom
--release builds for x86#5847dylan-apollo merged 2 commits intonextfrom
Conversation
dylan-apollo
requested review from
SimonSapin,
TylerBloom,
dariuszkuc,
duckki,
goto-bus-stop,
lrlna and
sachindshinde
as code owners
lennyburdette
approved these changes
Aug 19, 2024
Contributor
sachindshinde
left a comment
sachindshinde
left a comment
There was a problem hiding this comment.
Note that not everything was a HashMap/HashSet in apollo-federation/src/query_graph/extract_subgraphs_from_supergraph.rs prior to #5827 . If I revert just the changes to that file (and cost_spec_definition.rs), it's able to compile for me (not sure if it works for y'all).
dylan-apollo
force-pushed
the
dylan/revert-index
branch
from
88fe4ac to
8a9326f
Compare
sachindshinde
approved these changes
Aug 19, 2024
Contributor
|
I wish I could understand what went wrong with the HashMaps/Sets. BTW, why don't we push to |
dylan-apollo
added a commit
that referenced
this pull request
Aug 20, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.