fix(federation): change HashMap/HashSet usage to IndexMap/IndexSet to avoid non-determinism#5827
Merged
sachindshinde merged 2 commits intodevfrom Aug 16, 2024
Merged
Conversation
Contributor
|
@sachindshinde, please consider creating a changeset entry in |
|
CI performance tests
|
2c95ac4 to
b590e5b
Compare
dariuszkuc
approved these changes
Aug 15, 2024
b590e5b to
b8ca12f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the tests was failing with a non-deterministic QP snapshot failure. I suspected this was due to usage of
HashMap/HashSet, and after converting all usages of them toapollo_compiler'sIndexMap/IndexSet, the test's QP snapshot is now consistent across 100 runs. (We probably don't need to convert all usages for this test to pass, but this may help reduce non-determinism/help reproducibility in the future.)