Skip to content

Fix entity detection in mismatch reporter#3235

Merged
clenfest merged 1 commit intomainfrom
clenfest/inconsistent_entity_fix
Apr 2, 2025
Merged

Fix entity detection in mismatch reporter#3235
clenfest merged 1 commit intomainfrom
clenfest/inconsistent_entity_fix

Conversation

@clenfest
Copy link
Contributor

@clenfest clenfest commented Apr 2, 2025

Fixes bug introduced in 2.10.0 where we could potentially throw in hintOnInconsistentEntity if subgraphs use @federation__key rather than @key.

@clenfest clenfest requested a review from a team as a code owner April 2, 2025 19:44
@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 2271e2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Apr 2, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 5f8eeefc771ad08a43eaaf30

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 2, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@clenfest clenfest merged commit b6a3301 into main Apr 2, 2025
17 checks passed
@clenfest clenfest deleted the clenfest/inconsistent_entity_fix branch April 2, 2025 19:56
clenfest added a commit that referenced this pull request Apr 14, 2025
Fixes bug introduced in `2.10.0` where we could potentially throw in
`hintOnInconsistentEntity` if subgraphs use `@federation__key` rather
than `@key`.
clenfest added a commit that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants