Skip to content

Fix entity detection in mismatch reporter #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clenfest merged 1 commit into from
Apr 2, 2025
Merged

Fix entity detection in mismatch reporter #3235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composition-js/src/merging/merge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,7 @@ class Merger {
supergraphElement: dest,
subgraphElements: sources,
// All we use the string of the next line for is to categorize source with a @key of the others.
elementToString: type => type.hasAppliedDirective('key') ? 'yes' : 'no',
elementToString: type => sourceAsEntity.find(entity => entity === type) ? 'yes' : 'no',
// Note that the first callback is for element that are "like the supergraph". As the supergraph has no @key ...
supergraphElementPrinter: (_, subgraphs) => `it has no @key in ${subgraphs}`,
otherElementsPrinter: (_, subgraphs) => ` but has some @key in ${subgraphs}`,
Expand Down