Implicitly upgrade federation version to the max required by any used directive#2929
Merged
tninesling merged 10 commits intomainfrom Feb 5, 2024
Merged
Implicitly upgrade federation version to the max required by any used directive#2929tninesling merged 10 commits intomainfrom
tninesling merged 10 commits intomainfrom
Conversation
…res something higher
…rade hint can propagate
…implicit upgrades
|
@tninesling: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: d831c00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
reviewed
Feb 5, 2024
Co-authored-by: Chris Lenfest <clenfest@apollographql.com>
clenfest
approved these changes
Feb 5, 2024
Contributor
clenfest
left a comment
clenfest
left a comment
There was a problem hiding this comment.
LGTM, make sure you squash.
tninesling
added a commit
that referenced
this pull request
Feb 5, 2024
This change updates the changeset log from #2929 to indicate patch version bumps instead of minor version bumps.
clenfest
pushed a commit
that referenced
this pull request
Mar 21, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/composition@2.7.2 ### Patch Changes - When a linked directive requires a federation version higher than the linked federation spec, upgrade to the implied version and issue a hint ([#2929](#2929)) - Stop emitting "inconsistent value type" hints against definitions where the type is marked `@external` or all fields are marked `@external`. ([#2951](#2951)) - Introduce a new composition hint pertaining specifically to progressive `@override` usage (when a `label` argument is present). ([#2922](#2922)) - Updated dependencies \[[`33b937b18d3c7ca6af14b904696b536399e597d1`](33b937b), [`09cd3e55e810ee513127b7440f5b11af7540c9b0`](09cd3e5), [`d7189a86c27891af408d3d0184db6133d3342967`](d7189a8)]: - @apollo/federation-internals@2.7.2 - @apollo/query-graphs@2.7.2 ## @apollo/gateway@2.7.2 ### Patch Changes - Remove out-of-band reporting in the gateway and provide a warning for users who have the endpoint configured. ([#2946](#2946)) - Updated dependencies \[[`33b937b18d3c7ca6af14b904696b536399e597d1`](33b937b), [`09cd3e55e810ee513127b7440f5b11af7540c9b0`](09cd3e5), [`d7189a86c27891af408d3d0184db6133d3342967`](d7189a8), [`33506bef6d755c58400081824167711c1747ee40`](33506be), [`1f72f2a361a83ebaaf15ae052f5ca9a93fc18bfc`](1f72f2a)]: - @apollo/composition@2.7.2 - @apollo/federation-internals@2.7.2 - @apollo/query-planner@2.7.2 ## @apollo/federation-internals@2.7.2 ### Patch Changes - When a linked directive requires a federation version higher than the linked federation spec, upgrade to the implied version and issue a hint ([#2929](#2929)) - When auto-upgrading a subgraph (i.e. one that does not explicitly @link the federation spec) do not go past v2.4. This is so that subgraphs will not inadvertently require the latest join spec (which cause the router or gateway not to start if running an older version). ([#2933](#2933)) - Add new `generateQueryFragments` option to query planner config ([#2958](#2958)) If enabled, the query planner will extract inline fragments into fragment definitions before sending queries to subgraphs. This can significantly reduce the size of the query sent to subgraphs, but may increase the time it takes to plan the query. ## @apollo/query-graphs@2.7.2 ### Patch Changes - Updated dependencies \[[`33b937b18d3c7ca6af14b904696b536399e597d1`](33b937b), [`09cd3e55e810ee513127b7440f5b11af7540c9b0`](09cd3e5), [`d7189a86c27891af408d3d0184db6133d3342967`](d7189a8)]: - @apollo/federation-internals@2.7.2 ## @apollo/query-planner@2.7.2 ### Patch Changes - When auto-upgrading a subgraph (i.e. one that does not explicitly @link the federation spec) do not go past v2.4. This is so that subgraphs will not inadvertently require the latest join spec (which cause the router or gateway not to start if running an older version). ([#2933](#2933)) - Add new `generateQueryFragments` option to query planner config ([#2958](#2958)) If enabled, the query planner will extract inline fragments into fragment definitions before sending queries to subgraphs. This can significantly reduce the size of the query sent to subgraphs, but may increase the time it takes to plan the query. - Updated dependencies \[[`33b937b18d3c7ca6af14b904696b536399e597d1`](33b937b), [`09cd3e55e810ee513127b7440f5b11af7540c9b0`](09cd3e5), [`d7189a86c27891af408d3d0184db6133d3342967`](d7189a8)]: - @apollo/federation-internals@2.7.2 - @apollo/query-graphs@2.7.2 ## @apollo/subgraph@2.7.2 ### Patch Changes - Updated dependencies \[[`33b937b18d3c7ca6af14b904696b536399e597d1`](33b937b), [`09cd3e55e810ee513127b7440f5b11af7540c9b0`](09cd3e5), [`d7189a86c27891af408d3d0184db6133d3342967`](d7189a8)]: - @apollo/federation-internals@2.7.2 ## apollo-federation-integration-testsuite@2.7.2 ### Patch Changes - Add new `generateQueryFragments` option to query planner config ([#2958](#2958)) If enabled, the query planner will extract inline fragments into fragment definitions before sending queries to subgraphs. This can significantly reduce the size of the query sent to subgraphs, but may increase the time it takes to plan the query. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The recent addition of
SourceSpecDefinitionsurfaced a case where a subgraph with a@linkto federation < 2.7 and a@linkto the source spec (which requires federation >= 2.7) results in an unexpected error during composition. Validation for this case was introduced in #2914, raising a composition error when the versions are mismatched.Since the existing behavior will implicitly upgrade to a later minor version of federation when two subgraphs are mismatched, it makes sense to do the same with feature requirements.
Example
Subgraph A has a
@linkto fed version 2.5Subgraph B has a
@linkto fed version 2.7Subgraph C has a
@linkto fed version 2.5 and a separate@linkto the source specPrevious behavior:
New behavior: