Skip to content

[ZEPPELIN-791] Build infra: move all RAT to root pom.xml #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DmytroShkvyra wants to merge 3 commits into from
Closed

[ZEPPELIN-791] Build infra: move all RAT to root pom.xml #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
398fb62
[ZEPPELIN-791] Build infra: move all RAT to root pom.xml
DmytroShkvyra Feb 27, 2017
2c27342
[ZEPPELIN-791] Exclude **.test.js
DmytroShkvyra Feb 27, 2017
296662a
[ZEPPELIN-791] add widcard
DmytroShkvyra Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 51 additions & 16 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,39 @@
<exclude>**/interpreter-setting.json</exclude>
<exclude>**/constants.json</exclude>
<exclude>scripts/**</exclude>
<exclude>**/**/*.log</exclude>
Copy link
Member

@felixcheung felixcheung Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks this exclude is removed - could you add it back?

dependency-reduced-pom.xm

Copy link
Contributor Author

@DmytroShkvyra DmytroShkvyra Mar 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @felixcheung ths exclusion already in pom.xml. I just moved by
f9bc7a9 - Luciano Resende <[email protected]> Sep 5, 2016 [ZEPPELIN-1409] Refactor RAT build on Travis.CI configuration
PR

          <exclude>docs/sitemap.txt</exclude>
         <exclude>docs/search_data.json</exclude>
         <exclude>**/dependency-reduced-pom.xml</exclude>

         <!-- bundled from anchor -->
         <exclude>docs/assets/themes/zeppelin/js/anchor.min.js</exclude>

         <!-- bundled from toc -->

Copy link
Contributor Author

@DmytroShkvyra DmytroShkvyra Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @felixcheung it is already in another section (see #1401)

<exclude>**/**/logs/**</exclude>

<!-- bundled from zeppelin-web -->
<exclude>**/test/karma.conf.js</exclude>
<exclude>**/test/spec/**</exclude>
<exclude>**/.babelrc</exclude>
<exclude>**/.bowerrc</exclude>
<exclude>.editorconfig</exclude>
<exclude>.eslintrc</exclude>
<exclude>**/.tmp/**</exclude>
<exclude>**/target/**</exclude>
<exclude>**/node/**</exclude>
<exclude>**/node_modules/**</exclude>
<exclude>**/bower_components/**</exclude>
<exclude>**/dist/**</exclude>
<exclude>**/.buildignore</exclude>
<exclude>**/.npmignore</exclude>
<exclude>**/.jshintrc</exclude>
<exclude>**/yarn.lock</exclude>
<exclude>**/bower.json</exclude>
<exclude>**/src/fonts/Patua-One*</exclude>
<exclude>**/src/fonts/patua-one*</exclude>
<exclude>**/src/fonts/Roboto*</exclude>
<exclude>**/src/fonts/roboto*</exclude>
<exclude>**/src/fonts/fontawesome*</exclude>
<exclude>**/src/fonts/font-awesome*</exclude>
<exclude>**/src/styles/font-awesome*</exclude>
<exclude>**/src/fonts/Simple-Line*</exclude>
<exclude>**/src/fonts/simple-line*</exclude>
<exclude>**/src/fonts/Source-Code-Pro*</exclude>
<exclude>**/src/fonts/source-code-pro*</exclude>
<exclude>**/src/**/**.test.js</exclude>

<!-- from SQLLine 1.0.2, see ZEPPELIN-2135 -->
<exclude>**/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java</exclude>
Expand Down Expand Up @@ -947,22 +980,24 @@
<exclude>**/package.json</exclude>

<!-- compiled R packages (binaries) -->
<exclude>R/lib/**</exclude>
<exclude>r/lib/**</exclude>

<!--R-related files with alternative licenses-->
<exclude>r/R/rzeppelin/R/globals.R</exclude>
<exclude>r/R/rzeppelin/R/common.R</exclude>
<exclude>r/R/rzeppelin/R/protocol.R</exclude>
<exclude>r/R/rzeppelin/R/rServer.R</exclude>
<exclude>r/R/rzeppelin/R/scalaInterpreter.R</exclude>
<exclude>r/R/rzeppelin/R/zzz.R</exclude>
<exclude>r/src/main/scala/scala/Console.scala</exclude>
<exclude>r/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/Package.scala</exclude>
<exclude>r/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/RClient.scala</exclude>
<!--The following files are mechanical-->
<exclude>r/R/rzeppelin/DESCRIPTION</exclude>
<exclude>r/R/rzeppelin/NAMESPACE</exclude>
<exclude>**/R/lib/**</exclude>
<exclude>**/r/lib/**</exclude>

<!--R-related files with alternative licenses-->

<exclude>**/R/rzeppelin/R/globals.R</exclude>
<exclude>**/R/rzeppelin/R/common.R</exclude>
<exclude>**/R/rzeppelin/R/protocol.R</exclude>
<exclude>**/R/rzeppelin/R/rServer.R</exclude>
<exclude>**/R/rzeppelin/R/scalaInterpreter.R</exclude>
<exclude>**/R/rzeppelin/R/zzz.R</exclude>
<exclude>**/src/main/scala/scala/Console.scala</exclude>
<exclude>**/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/Package.scala</exclude>
<exclude>**/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/RClient.scala</exclude>

<!--The following files are mechanical-->
<exclude>**/R/rzeppelin/DESCRIPTION</exclude>
<exclude>**/R/rzeppelin/NAMESPACE</exclude>
</excludes>
</configuration>

Expand Down
37 changes: 0 additions & 37 deletions r/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,43 +190,6 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
<excludes>
<exclude>lib/**</exclude>
<exclude>**/r/lib/**</exclude>
<!--The following files are subject to the BSD-license or variants,
as shown in the file headers-->
<exclude>**/R/rzeppelin/R/globals.R</exclude>
<exclude>**/R/rzeppelin/R/common.R</exclude>
<exclude>**/R/rzeppelin/R/protocol.R</exclude>
<exclude>**/R/rzeppelin/R/rServer.R</exclude>
<exclude>**/R/rzeppelin/R/scalaInterpreter.R</exclude>
<exclude>**/R/rzeppelin/R/zzz.R</exclude>
<exclude>**/scala/Console.scala</exclude>
<exclude>**/zeppelin/rinterpreter/rscala/Package.scala</exclude>
<exclude>**/zeppelin/rinterpreter/rscala/RClient.scala</exclude>
<!--End of files subject to BSD-license.-->
<exclude>**/.idea/</exclude>
<!--The following files are mechanical-->
<exclude>**/R/rzeppelin/DESCRIPTION</exclude>
<exclude>**/R/rzeppelin/NAMESPACE</exclude>
<!--End of mechanical R files-->
<exclude>**/*.iml</exclude>
<exclude>.gitignore</exclude>
<exclude>**/.settings/*</exclude>
<exclude>**/.classpath</exclude>
<exclude>**/.project</exclude>
<exclude>**/target/**</exclude>
<exclude>**/derby.log</exclude>
<exclude>**/metastore_db/</exclude>
<exclude>**/README.md</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
</excludes>
</configuration>
</plugin>

<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
Expand Down
46 changes: 0 additions & 46 deletions zeppelin-web/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,52 +58,6 @@
</configuration>
</plugin>

<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
<excludes>
<exclude>**/.idea/</exclude>
<exclude>**/*.iml</exclude>
<exclude>.git/</exclude>
<exclude>.gitignore</exclude>
<exclude>.babelrc</exclude>
<exclude>.bowerrc</exclude>
<exclude>.editorconfig</exclude>
<exclude>.jscsrc</exclude>
<exclude>.eslintrc</exclude>
<exclude>.tmp/**</exclude>
<exclude>**/.settings/*</exclude>
<exclude>**/.classpath</exclude>
<exclude>**/.project</exclude>
<exclude>**/target/**</exclude>
<exclude>node/**</exclude>
<exclude>node_modules/**</exclude>
<exclude>bower_components/**</exclude>
<exclude>src/**/*.test.js</exclude>
<exclude>reports/**</exclude>
<exclude>dist/**</exclude>
<exclude>src/.buildignore</exclude>
<exclude>src/fonts/fontawesome*</exclude>
<exclude>src/fonts/font-awesome*</exclude>
<exclude>src/styles/font-awesome*</exclude>
<exclude>src/fonts/Simple-Line*</exclude>
<exclude>src/fonts/simple-line*</exclude>
<exclude>src/fonts/Patua-One*</exclude>
<exclude>src/fonts/patua-one*</exclude>
<exclude>src/fonts/Roboto*</exclude>
<exclude>src/fonts/roboto*</exclude>
<exclude>src/fonts/Source-Code-Pro*</exclude>
<exclude>src/fonts/source-code-pro*</exclude>
<exclude>bower.json</exclude>
<exclude>**/package.json</exclude>
<exclude>**/.npmignore</exclude>
<exclude>yarn.lock</exclude>
<exclude>*.md</exclude>
</excludes>
</configuration>
</plugin>

<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
Expand Down