[ZEPPELIN-1409] Refactor RAT build on Travis.CI configuration#1401
[ZEPPELIN-1409] Refactor RAT build on Travis.CI configuration#1401lresende wants to merge 2 commits intoapache:masterfrom
Conversation
|
One of the builds failed with the following, which seems not related
|
|
@bzz @Leemoonsoo Please review |
| @@ -34,6 +34,10 @@ addons: | |||
|
|
|||
| matrix: | |||
There was a problem hiding this comment.
Thanks for the contribution. Shell we have better comment here?
| <version>${jetty.version}</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
|
I think having a separate profile it is reasonable approach for CI. Though I also think there is value in keeping the default behaviour for local Dev workflow and make RAT check on by default. It might be like this for some time ZEPPELIN-278 In order to communicate the value of such fix better, I would suggest linking to JIRA/here the logs of CI builds that have failed due to RAT issue as well (like current master, #1400, etc). |
Create a specific build for checking license compliance with RAT and avoid running these checks on every build that compose the PR build.
Following the same pattern used for maven tests, enable RAT to run by default, but support disabling it with -DskipRat. Travis CI will run RAT once, on the RAT build, and disable RAT checks on all other build profiles.
|
@bzz this has now been updated to follow the same pattern used for maven tests, enable RAT to run by default, but support disabling it with -DskipRat. Travis CI will run RAT once, on the RAT build, and disable RAT checks on all other build profiles. |
|
Then how about we use -DskipRat on all building profiles, and have a profile that run only RAT without building? Build time is pretty long, so it would be nice to separate some easy check that do not need compilation or specific settings separated, we would keep the CI feedback loop shorter and it would also be easier to know what failed without going to the log. It could probably also be applied to things like Style Check or Unit Tests later |
|
@corneadoug This is exactly what is implemented on this pr. |
|
@lresende My bad, when I first read I understood that RAT would be included in one profile that would still build everything. (just like we do with the -DskipTests) |
|
LGTM |
|
Thank you @lresende ! Looks great to me, merging to master as a hotfix, if there is no further discussion. CI fails on a single profile with un-related flaky test |
What is this PR for?
Create a specific build for checking license compliance with RAT
and avoid running these checks on every build that compose the
PR build.
As for normal development builds, this follows the same pattern
used for maven tests, RAT is enabled to run by default, but now
there is support disabling it with -DskipRat.
Travis CI will run RAT once, on the RAT build, and disable RAT
checks on all other build profiles.
What type of PR is it?
[Enhancement]
What is the Jira issue?