[ZEPPELIN-791] Build infra: move all RAT to root pom.xml #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@felixcheung Could you review my PR? |
felixcheung
requested changes
Mar 3, 2017
| <exclude>**/interpreter-setting.json</exclude> | ||
| <exclude>**/constants.json</exclude> | ||
| <exclude>scripts/**</exclude> | ||
| <exclude>**/**/*.log</exclude> |
Member
There was a problem hiding this comment.
it looks this exclude is removed - could you add it back?
dependency-reduced-pom.xm
Contributor
Author
There was a problem hiding this comment.
Hi @felixcheung ths exclusion already in pom.xml. I just moved by
f9bc7a9 - Luciano Resende <[email protected]> Sep 5, 2016 [ZEPPELIN-1409] Refactor RAT build on Travis.CI configuration
PR
<exclude>docs/sitemap.txt</exclude> <exclude>docs/search_data.json</exclude> <exclude>**/dependency-reduced-pom.xml</exclude> <!-- bundled from anchor --> <exclude>docs/assets/themes/zeppelin/js/anchor.min.js</exclude> <!-- bundled from toc -->
Contributor
Author
There was a problem hiding this comment.
Hi @felixcheung it is already in another section (see #1401)
Member
|
merging if no more comment |
Member
|
merged to master. |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2018
### What is this PR for? rat plugin for r interpreter fail, seems to be related with #2089 It doesn't need to be included in 0.8.0 release, but want it to be cherry-picked into `branch-0.8` for 0.8.x releases, so release manager doesn't have issue with running `dev/publish_release.sh` ### What type of PR is it? Hot Fix ### What is the Jira issue? [ZEPPELIN-3441](https://issues.apache.org/jira/browse/ZEPPELIN-3441) ### How should this be tested? Run `mvn verify -Pr` should pass In CI, first matrix should pass. (https://travis-ci.org/minahlee/zeppelin/builds/374917837) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes #2957 from minahlee/hotfix/ratR and squashes the following commits: 1d4ae6c [Mina Lee] Add rat check for r in travis c323c4a [Mina Lee] Fix rat check exclude directory for r
asfgit
pushed a commit
that referenced
this pull request
May 9, 2018
rat plugin for r interpreter fail, seems to be related with #2089 It doesn't need to be included in 0.8.0 release, but want it to be cherry-picked into `branch-0.8` for 0.8.x releases, so release manager doesn't have issue with running `dev/publish_release.sh` Hot Fix [ZEPPELIN-3441](https://issues.apache.org/jira/browse/ZEPPELIN-3441) Run `mvn verify -Pr` should pass In CI, first matrix should pass. (https://travis-ci.org/minahlee/zeppelin/builds/374917837) * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes #2957 from minahlee/hotfix/ratR and squashes the following commits: 1d4ae6c [Mina Lee] Add rat check for r in travis c323c4a [Mina Lee] Fix rat check exclude directory for r (cherry picked from commit 3712ce6) Signed-off-by: Jeff Zhang <[email protected]>
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
rat plugin for r interpreter fail, seems to be related with apache#2089 It doesn't need to be included in 0.8.0 release, but want it to be cherry-picked into `branch-0.8` for 0.8.x releases, so release manager doesn't have issue with running `dev/publish_release.sh` Hot Fix [ZEPPELIN-3441](https://issues.apache.org/jira/browse/ZEPPELIN-3441) Run `mvn verify -Pr` should pass In CI, first matrix should pass. (https://travis-ci.org/minahlee/zeppelin/builds/374917837) * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes apache#2957 from minahlee/hotfix/ratR and squashes the following commits: 1d4ae6c [Mina Lee] Add rat check for r in travis c323c4a [Mina Lee] Fix rat check exclude directory for r (cherry picked from commit 3712ce6) Signed-off-by: Jeff Zhang <[email protected]> (cherry picked from commit d41c634) Change-Id: I69d4f615e182b320507d24e09c353fa72ad3f76f
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? rat plugin for r interpreter fail, seems to be related with apache#2089 It doesn't need to be included in 0.8.0 release, but want it to be cherry-picked into `branch-0.8` for 0.8.x releases, so release manager doesn't have issue with running `dev/publish_release.sh` ### What type of PR is it? Hot Fix ### What is the Jira issue? [ZEPPELIN-3441](https://issues.apache.org/jira/browse/ZEPPELIN-3441) ### How should this be tested? Run `mvn verify -Pr` should pass In CI, first matrix should pass. (https://travis-ci.org/minahlee/zeppelin/builds/374917837) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes apache#2957 from minahlee/hotfix/ratR and squashes the following commits: 1d4ae6c [Mina Lee] Add rat check for r in travis c323c4a [Mina Lee] Fix rat check exclude directory for r
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
rat plugin for r interpreter fail, seems to be related with apache#2089 It doesn't need to be included in 0.8.0 release, but want it to be cherry-picked into `branch-0.8` for 0.8.x releases, so release manager doesn't have issue with running `dev/publish_release.sh` Hot Fix [ZEPPELIN-3441](https://issues.apache.org/jira/browse/ZEPPELIN-3441) Run `mvn verify -Pr` should pass In CI, first matrix should pass. (https://travis-ci.org/minahlee/zeppelin/builds/374917837) * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes apache#2957 from minahlee/hotfix/ratR and squashes the following commits: 1d4ae6c [Mina Lee] Add rat check for r in travis c323c4a [Mina Lee] Fix rat check exclude directory for r (cherry picked from commit 3712ce6) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
It is better have a single place where we manage project-wise RAT exclusions for a contributions under licenses different from Apache, then let maven sub-modules have them as we do now (makes things harder to track)
What type of PR is it?
[Improvement]
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-791
How should this be tested?
mvn verify -DskipTests
Screenshots (if appropriate)
Questions:
Does the licenses files need update? - No
Is there breaking changes for older versions? - No
Does this needs documentation? - No
Questions: