[HOTFIX] Make Spark download stable on CI #1709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2016
Closed
Member
|
This is awesome and thanks for great, great effort of @bzz Let me add 1 small detail for who not to see the full history. |
Member
Author
|
CI is green, merging to master as a HOTFIX |
Member
|
+1 |
ghost
mentioned this pull request
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2016
### What is this PR for? The matplotlib tests have stalled as a result of conda downloading version 2.0.0b1. While this was an old beta version and the issue has been fixed upstream (conda-forge/matplotlib-feedstock#86), we still have not tested the inline backend for 2.0.0 which will be a release with a lot of major changes, hence this PR should be made anyway. I am also partially undoing one of the changes made in #1709 which suppressed the output of the dependency installation from conda. This change was very puzzling to me since dependency info isn't that verbose. I ended up determining the cause of this issue because I reverted this change and was then able to see the dependency versions in the log. I could see suppressing this being necessary for the R packages in case they aren't cached and a wall of compiler output gets printed out, but I see no real justification to mute it for python packages, especially given that they will only be installed for two short profiles. ### What type of PR is it? Hot Fix ### What is the Jira issue? [ZEPPELIN-1779](https://issues.apache.org/jira/browse/ZEPPELIN-1779) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alex Goodman <agoodm@users.noreply.github.com> Closes #1741 from agoodm/ZEPPELIN-1779 and squashes the following commits: 1211a2f [Alex Goodman] Ensure matplotlib version is 1.5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
There has been issues with downloading\caching Spark, esp in #1689 #1696
This is hotfix for Spark download on CI.
What type of PR is it?
Hot Fix
Todos
download-maven-plugincache for Spark download/target/somvn cleanworks as expected./testing/install_external_dependencies.shHow should this be tested?
In CI logs, Spark should be downloaded by
spark-dependenciesand cached under${HOME}/.m2/repository/.cache/maven-download-pluginQuestions: