[ZEPPELIN-1709] Update checkstyle rule file, plugin #1689

1ambda · 2016-11-28T05:09:38Z

What is this PR for?

We have

outdated checkstyle.xml
old maven checkstyle plugin
no detailed style plugin guide (e.g available plugins, how to use them in your IDEA)

By fixing those issues, we can keep our code clean. It will results the number of rebase count (reduced conflict due to just style) and boost our productivity.

important note

This PR set an option to print all checkstyle warnings into stdout. The reason is, people should be told about invalid styles of not only errors but also warnings.
They would fix it progressionally. (unfortunately, we can fix all warnings in this PR. too much)
Once those warnings are all fixed, we can set <violationSeverity>warning</violationSeverity> to fail build even when checkstyle warning is occurred. That means we have more strict rule for our java code :)

            <consoleOutput>true</consoleOutput>
            <!-- TODO: <violationSeverity>warning</violationSeverity> -->

What type of PR is it?

[Improvement]

Todos

- update check style plugin (6.19, the most recent for java 7)
- update checkstyle.xml (brought from checkstyle 6.19 release)
- fix some styles
- print checkstyle WARN
- update docs

What is the Jira issue?

ZEPPELIN-1709

How should this be tested?

mvn validate -Denforcer.skip=true

Questions:

Does the licenses files need update - NO
Is there breaking changes for older versions - NO
Does this needs documentation - NO, but I added some docs about how to use checkstyle.xml in IDEA ([ZEPPELIN-1709] docs: Describe how to use checkstyle plugins #1690)

1ambda · 2016-11-28T05:19:53Z

\cc @bzz for review thanks!

1ambda · 2016-11-28T05:40:14Z

Failed due to log size limitation of travis CI

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

We might disable <consoleOutput>true</consoleOutput> only in CI
Execute checkstyle in the dedicated build profile (and skip checkstyle in all other profiles)

I think option 2 is better. since we can split test failure with styling validation failure

bzz · 2016-11-28T10:07:26Z

Thank you @1ambda !
I think it's a great idea to have checkstyle off the most of profiles, but add a new one with just checkstyle.

After CI finishes, let's post the CI time statistics in PR description, in order to verify the hypothesis that this change actually does speed up the CI build.

bzz · 2016-11-29T03:58:11Z

Looks great to me, thank you @1ambda !

May be, as soon as CI is green let's try to squash some commits, before merging it in - 37 may be a bit too much to be useful in merge commit message summary.

Going to merge to master, if there is no further discussion, right after that.

bzz · 2016-11-29T07:45:15Z

Multiple CI profiles failed on downloading spark source release

[ERROR] Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.3.0:wget (download-pyspark-files) on project zeppelin-spark-dependencies_2.11: IO Error: Could not get content -> [Help 1]
[ERROR]

@1ambda why removing ls command in CI? It was used to identify cache misses.

bzz · 2016-11-29T09:32:02Z

Prev plugin version seems to have same behavior

[ERROR] Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.2.1:wget (download-pyspark-files) on project zeppelin-spark-dependencies_2.10: IO Error: Could not get content -> [Help 1]

bzz · 2016-11-29T10:14:09Z

Here are more detailed logs

[WARNING] Retrying (4 more)
Downloading: http://archive.apache.org/dist/spark/spark-2.0.1/spark-2.0.1.tgz
org.apache.maven.wagon.TransferFailedException: Failed to transfer file: http://archive.apache.org/dist/spark/spark-2.0.1/spark-2.0.1.tgz. Return code is: 503 , ReasonPhrase:Service Unavailable.
	at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:1039)
	at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:977)
	at org.apache.maven.wagon.StreamWagon.getInputStream(StreamWagon.java:116)
	at org.apache.maven.wagon.StreamWagon.getIfNewer(StreamWagon.java:88)
	at org.apache.maven.wagon.StreamWagon.get(StreamWagon.java:61)
	at com.googlecode.WGet.doGet(WGet.java:293)

1ambda · 2016-11-30T08:24:01Z

I will rebase this.

### What is this PR for? The sub issue of #1689 (PRs are splitted due to `contribute.md` exists in different branch `gh-pages`) - Describe how to IDE plugins to contribute consistent code ### What type of PR is it? [Documentation] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1709 ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions - NO * Does this needs documentation - NO Author: 1ambda <1amb4a@gmail.com> Closes #1690 from 1ambda/docs/update-checkstyle-plugins and squashes the following commits: 9d77726 [1ambda] docs: Split download, setting links 484714a [1ambda] fix: typo 099479c [1ambda] docs: Update checkstyle plugins

bzz · 2016-11-30T14:20:55Z

@1ambda I have created a HOTFIX for CI Spark download in #1709 so after merging it, let's rebase and see if that fixed the issue.

I'm a bit confused, do you want to continue working here or in #1696 though? Or they can be rebased one after another

1ambda · 2016-11-30T14:27:37Z

@bzz I will work on here and add some small details from #1696 later
(e.g adding profile for checkstyle not to skip checkstyle in all other profiles, work around for codehaus repository issue)

bzz · 2016-11-30T14:30:09Z

.travis.yml

+
+    # Test checkstyle
+    - jdk: "oraclejdk7"
+      env: SCALA_VER="2.11" SPARK_VER="1.6.1" HADOOP_VER="2.3" PROFILE="-Pspark-1.6 -Pr -Phadoop-2.3 -Ppyspark -Psparkr -Pscala-2.11" BUILD_FLAG="package -DskipTests -DskipRat -Dcheckstyle.skip=true" TEST_FLAG="verify -DskipRat" TEST_PROJECTS="-pl zeppelin-interpreter,zeppelin-zengine,zeppelin-server,zeppelin-display,spark-dependencies,spark,r -Dtest=org.apache.zeppelin.rest.*Test,org.apache.zeppelin.spark.* -DfailIfNoTests=false"


@1ambda I think this checkstyle profile should be run on all the projects not just a subset of -pl ...

@bzz sure. I meaned the profile which printing all warnings <consoleOutput>true<consoleOutput>

so that config be shared in children projects

its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-interpreter --- [INFO] There are 5 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] (indentation) Indentation: 'Collection' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242] (indentation) Indentation: 'getClassName' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59] (indentation) Indentation: 'extends' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.587 s] [INFO] Zeppelin: Interpreter .............................. FAILURE [ 0.901 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Zengine 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-zengine --- [INFO] There are 13 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[348] (indentation) Indentation: '.' have incorrect indentation level 5, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[412] (indentation) Indentation: '"Information From loaded Interpreter Setting Ref - {} "' have incorrect indentation level10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[37] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[38] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[39] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[44] (indentation) Indentation: 'JsonDeserializationContext' have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[229] (indentation) Indentation: '&&' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[230] (indentation) Indentation: '&&' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[306] (indentation) Indentation: 'interpreterHasUser' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/notebook/Paragraph.java:[307] (indentation) Indentation: 'isUserAuthorizedToAccessInterpreter' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java:[440] (indentation) Indentation: 'getRepo' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/notebook/utility/IdHashes.java:[30] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level should be one ofthe following: 6, 55, 58. [ERROR] src/main/java/org/apache/zeppelin/notebook/utility/IdHashes.java:[31] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level should be one ofthe following: 6, 55, 58. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.116 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.237 s] [INFO] Zeppelin: Zengine .................................. FAILURE [ 0.612 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Spark 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-spark_2.10 --- [INFO] There are 10 errors reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/spark/DepInterpreter.java:[209] (indentation) Indentation:'intp' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[418] (indentation) Indentation: 'e' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[493] (indentation) Indentation: 'array initialization' child have incorrect indentation level 6, expected level should be one of the following: 8, 39, 42. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1158] (indentation) Indentation: '||' have incorrect indentation level 11, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1159] (indentation) Indentation: '||' have incorrect indentation level 11, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1160] (indentation) Indentation: '||' have incorrect indentation level 11, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1451] (indentation) Indentation: 'array initialization' child have incorrect indentation level 12, expected level should be 14. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1454] (indentation) Indentation: 'array initialization' child have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1463] (indentation) Indentation: 'array initialization' child have incorrect indentation level 14, expected level should be 16. [ERROR] src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1465] (indentation) Indentation: 'array initialization' child have incorrect indentation level 10, expected level should be 12. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.472 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.153 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 0.867 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.214 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.644 s] [INFO] Zeppelin: Spark .................................... FAILURE [ 0.348 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Shell interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-shell --- [INFO] There are 5 errors reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/shell/security/ShellSecurityImpl.java:[39] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/shell/security/ShellSecurityImpl.java:[46] (indentation) Indentation: 'properties' have incorrect indentation level 12, expected level should be 14. [ERROR] src/main/java/org/apache/zeppelin/shell/security/ShellSecurityImpl.java:[47] (indentation) Indentation: 'properties' have incorrect indentation level 12, expected level should be 14. [ERROR] src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java:[94] (indentation) Indentation: '+' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java:[105] (indentation) Indentation: '+' have incorrect indentation level 10, expected level should be 12. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.454 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.074 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 0.889 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.173 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.723 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.640 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.181 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.135 s] [INFO] Zeppelin: Shell interpreter ........................ FAILURE [ 0.135 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: JDBC interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-jdbc --- [INFO] There are 6 errors reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[259] (indentation) Indentation:'jdbcUserConfigurationsMap' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[282] (indentation) Indentation:'getJDBCConfiguration' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[291] (indentation) Indentation:'getEntityName' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[302] (indentation) Indentation:'new' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[305] (indentation) Indentation:'connectionFactory' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:[532] (indentation) Indentation:'getJDBCConfiguration' have incorrect indentation level 6, expected level should be 8. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.206 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.011 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 0.778 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.175 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.481 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.365 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.160 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.142 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.142 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [ 0.476 s] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 0.272 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 0.224 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.200 s] [INFO] Zeppelin: JDBC interpreter ......................... FAILURE [ 0.186 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Lens interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-lens --- [INFO] There are 18 errors reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[79] (indentation) Indentation: 'new' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[81] (indentation) Indentation: 'new' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[103,37] (whitespace) WhitespaceAround: '|' is not preceded with whitespace. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[103,38] (whitespace) WhitespaceAround: '|' is not followed by whitespace. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[106] (indentation) Indentation:'+' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[110,37] (whitespace) WhitespaceAround: '|' is not preceded with whitespace. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[110,38] (whitespace) WhitespaceAround: '|' is not followed by whitespace. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[269] (indentation) Indentation:'new' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[272] (indentation) Indentation:'+' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[324] (indentation) Indentation:'result' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[351] (indentation) Indentation:'+' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/lens/LensInterpreter.java:[354] (indentation) Indentation:'+' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[41] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[105] (indentation) Indentation: 'BeanFactoryUtils' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[112] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[172] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[189] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/lens/LensJLineShellComponent.java:[209] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.334 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.060 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 0.781 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.184 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.514 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.388 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.155 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.133 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.133 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [ 0.438 s] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 0.256 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 0.269 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.165 s] [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 0.200 s] [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 0.170 s] [INFO] Zeppelin: Flink .................................... SUCCESS [ 0.241 s] [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 0.173 s] [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.141 s] [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.188 s] [INFO] Zeppelin: Lens interpreter ......................... FAILURE [ 0.260 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Elasticsearch interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-elasticsearch --- [INFO] There are 30 errors reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[80] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[81] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[82] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[83] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[84] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[85] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[86] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[87] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[88] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[89] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[90] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[91] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[92] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[93] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[94] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[95] (indentation) Indentation: '+' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[98] (indentation) Indentation: '"count"' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[125] (indentation) Indentation: 'property' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[134] (indentation) Indentation: '.' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[135] (indentation) Indentation: '.' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[136] (indentation) Indentation: '.' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[283] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[284] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[354] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[355] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[356] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[381] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[382] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[397] (indentation) Indentation: 'client' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[513] (indentation) Indentation: 'flattenJsonMap' have incorrect indentation level 12, expected level should be 14. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.534 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.155 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 0.954 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.185 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.617 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.410 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.168 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.149 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.154 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [ 0.645 s] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 0.258 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 0.211 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.174 s] [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 0.211 s] [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 0.176 s] [INFO] Zeppelin: Flink .................................... SUCCESS [ 0.235 s] [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 0.174 s] [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.152 s] [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.181 s] [INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 0.319 s] [INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [ 0.276 s] [INFO] Zeppelin: Elasticsearch interpreter ................ FAILURE [ 0.236 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: BigQuery interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-bigquery --- [INFO] There is 1 error reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/bigquery/BigQueryInterpreter.java:[267] (indentation) Indentation: 'final' have incorrect indentation level 4, expected level should be 6. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.719 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.440 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 1.008 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.219 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.587 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.416 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.170 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.152 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.143 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [ 0.464 s] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 0.238 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 0.199 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.199 s] [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 0.216 s] [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 0.175 s] [INFO] Zeppelin: Flink .................................... SUCCESS [ 0.211 s] [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 0.177 s] [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.141 s] [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.164 s] [INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 0.272 s] [INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [ 0.211 s] [INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 0.214 s] [INFO] Zeppelin: BigQuery interpreter ..................... FAILURE [ 0.159 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Alluxio interpreter 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-alluxio --- [INFO] There is 1 error reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/alluxio/AlluxioInterpreter.java:[74] (indentation) Indentation: '" on port "' have incorrect indentation level 6, expected level should be 8. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.176 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.072 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 0.946 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.168 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.633 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.435 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.168 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.145 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.137 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [ 0.602 s] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 0.338 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 0.275 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.177 s] [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 0.221 s] [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 0.174 s] [INFO] Zeppelin: Flink .................................... SUCCESS [ 0.315 s] [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 0.215 s] [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.144 s] [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.191 s] [INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 0.285 s] [INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [ 0.276 s] [INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 0.295 s] [INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [ 0.172 s] [INFO] Zeppelin: Alluxio interpreter ...................... FAILURE [ 0.212 s]

[INFO] ------------------------------------------------------------------------ [INFO] Building Zeppelin: Server 0.7.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ Downloading: http://repository.apache.org/snapshots/org/apache/zeppelin/zeppelin-zengine/0.7.0-SNAPSHOT/maven-metadata.xml [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-server --- [INFO] There are 18 errors reported by Checkstyle 6.19 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java:[120] (indentation) Indentation: 'this' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/realm/ActiveDirectoryGroupRealm.java:[122] (indentation) Indentation: 'CredentialProviderFactory' have incorrect indentation level 10, expected level should be12. [ERROR] src/main/java/org/apache/zeppelin/rest/CredentialRestApi.java:[69] (indentation) Indentation: 'new' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:[319] (indentation) Indentation: '=' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[474] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[481] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[498] (indentation) Indentation: 'new' have incorrect indentation level 6, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1178] (indentation) Indentation: 'String' have incorrect indentation level 5, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1179] (indentation) Indentation: 'String' have incorrect indentation level 5, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1194] (indentation) Indentation: 'String' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1195] (indentation) Indentation: 'String' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1208] (indentation) Indentation: 'Object' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1209] (indentation) Indentation: 'String' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1227] (indentation) Indentation: 'AngularObjectRegistry' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1330] (indentation) Indentation: '.' have incorrect indentation level 7, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1333] (indentation) Indentation: '.' have incorrect indentation level 7, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1399] (indentation) Indentation: '.' have incorrect indentation level 8, expected level should be 10. [ERROR] src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[1410] (indentation) Indentation: '.' have incorrect indentation level 6, expected level should be 8. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ........................................... SUCCESS [ 3.445 s] [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 1.333 s] [INFO] Zeppelin: Zengine .................................. SUCCESS [ 1.078 s] [INFO] Zeppelin: Display system apis ...................... SUCCESS [ 0.183 s] [INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 0.541 s] [INFO] Zeppelin: Spark .................................... SUCCESS [ 0.388 s] [INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.158 s] [INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.139 s] [INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.184 s] [INFO] Zeppelin: Livy interpreter ......................... SUCCESS [ 0.630 s] [INFO] Zeppelin: HBase interpreter ........................ SUCCESS [ 0.293 s] [INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [ 0.263 s] [INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.213 s] [INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [ 0.269 s] [INFO] Zeppelin: File System Interpreters ................. SUCCESS [ 0.208 s] [INFO] Zeppelin: Flink .................................... SUCCESS [ 0.243 s] [INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 0.169 s] [INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [ 0.163 s] [INFO] Zeppelin: Python interpreter ....................... SUCCESS [ 0.256 s] [INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 0.387 s] [INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [ 0.269 s] [INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [ 0.225 s] [INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [ 0.154 s] [INFO] Zeppelin: Alluxio interpreter ...................... SUCCESS [ 0.225 s] [INFO] Zeppelin: Scio ..................................... SUCCESS [ 0.369 s] [INFO] Zeppelin: web Application .......................... SUCCESS [ 1.602 s] [INFO] Zeppelin: Server ................................... FAILURE [ 1.983 s]

https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-6.19/src/main/resources/google_checks.xml

- Exclude targets in its own pom.xml instead of in parent's pom.xml

by replacing repository urls see more: travis-ci/travis-ci#4629

bzz · 2016-12-20T01:20:56Z

Only the last CI profile fails on very strange curcumstances:

16/12/19 04:54:08 INFO ApplicationMaster: Deleting staging directory .sparkStaging/application_1482123134765_0003
16/12/19 04:54:08 ERROR ApplicationMaster: Failed to cleanup staging dir .sparkStaging/application_1482123134765_0003
java.net.ConnectException: Call From testing-docker-7a57c244-e7fb-44fb-9664-5856f0534506/172.17.0.5 to localhost:39393 failed on connection exception: java.net.ConnectException: Connection refused; For more details see:  http://wiki.apache.org/hadoop/ConnectionRefused
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

There are no any error reports, but it looks like it can be related to Livy interpreter tests, so may be @zjffdu have seen it before?

16/12/19 04:53:44 INFO DiskBlockManager: Created local directory at /home/travis/build/apache/zeppelin/livy/target/tmp/MiniYarnMain/target/com.cloudera.livy.test.framework.MiniYarnMain/com.cloudera.livy.test.framework.MiniYarnMain-localDir-nm-0_0/usercache/travis/appcache/application_1482123134765_0003/blockmgr-1c256dca-2549-4041-96e5-65bb715e4937
16/12/19 04:53:44 INFO MemoryStore: MemoryStore started with capacity 265.4 MB

1ambda force-pushed the feat/update-checkstyle branch from 77b5f7e to 07f1693 Compare November 28, 2016 06:55

1ambda mentioned this pull request Nov 28, 2016

[ZEPPELIN-1709] docs: Describe how to use checkstyle plugins #1690

Closed

1ambda force-pushed the feat/update-checkstyle branch 9 times, most recently from 16e3a0d to 47a40af Compare November 28, 2016 09:19

1ambda force-pushed the feat/update-checkstyle branch from 0e09ca0 to 4b06892 Compare November 29, 2016 05:25

1ambda mentioned this pull request Nov 29, 2016

CI test for 1689 #1696

Closed

bzz mentioned this pull request Nov 29, 2016

Increase WGET retry number for Spark dowload 1ambda/zeppelin#3

Merged

This was referenced Nov 30, 2016

Direct Spark download url for CI as INFRA-12996 1ambda/zeppelin#5

Closed

Update to Spark 1.6.3 and 2.0.2 #1682

Closed

1ambda force-pushed the feat/update-checkstyle branch from 6b24e3e to 0f26ef2 Compare November 30, 2016 08:31

bzz mentioned this pull request Nov 30, 2016

[HOTFIX] Make Spark download stable on CI #1709

Closed

5 tasks

bzz reviewed Nov 30, 2016

View reviewed changes

1ambda force-pushed the feat/update-checkstyle branch from 49828bf to 66f3005 Compare December 19, 2016 02:32

1ambda added 25 commits December 19, 2016 11:32

chore: Use pluginManagement block

0ae2956

so that config be shared in children projects

chore: Remove useless failOnViolation config

092155d

its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html

chore: Remove duplicated exclude

1c3048e

chore: Use recent checkstyle runtime

e04de2f

chore: Update checkstyle.xml versio to 6.19

4155266

https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-6.19/src/main/resources/google_checks.xml

fix: Exclude checkstyle target properly

571b041

- Exclude targets in its own pom.xml instead of in parent's pom.xml

fix: Remove codehause repository errors

dcbc887

by replacing repository urls see more: travis-ci/travis-ci#4629

feat: Add profile for strict checkstyle

3931b2f

fix: Use package + verify

ecbea0f

fix: Use -Pstrict-checkstyle only in package

28c86cc

fix: Skip checkstyle in web, dist modules

ea5f259

fix: Change maven log option

e02d294

fix: Print WARN log in tests

eee30fb

fix: Add loose-checkstyle profile

b60f96e

fix: Remove checkstyle profile

66f3005

1ambda closed this Dec 19, 2016

1ambda reopened this Dec 19, 2016

1ambda closed this Apr 19, 2017

[ZEPPELIN-1709] Update checkstyle rule file, plugin #1689

[ZEPPELIN-1709] Update checkstyle rule file, plugin #1689

Uh oh!

Conversation

1ambda commented Nov 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Questions:

Uh oh!

1ambda commented Nov 28, 2016

Uh oh!

1ambda commented Nov 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bzz commented Nov 28, 2016

Uh oh!

bzz commented Nov 29, 2016

Uh oh!

bzz commented Nov 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bzz commented Nov 29, 2016

Uh oh!

bzz commented Nov 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1ambda commented Nov 30, 2016

Uh oh!

bzz commented Nov 30, 2016

Uh oh!

1ambda commented Nov 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bzz Nov 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1ambda Nov 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bzz commented Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

1ambda commented Nov 28, 2016 •

edited

Loading

1ambda commented Nov 28, 2016 •

edited

Loading

bzz commented Nov 29, 2016 •

edited

Loading

bzz commented Nov 29, 2016 •

edited

Loading

1ambda commented Nov 30, 2016 •

edited

Loading

bzz Nov 30, 2016 •

edited

Loading

1ambda Nov 30, 2016 •

edited

Loading

bzz commented Dec 20, 2016 •

edited

Loading