Skip to content

Conversation

@Leemoonsoo
Copy link
Member

What is this PR for?

Fix selenium test error described in ZEPPELIN-1009

What type of PR is it?

Hot Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1009

How should this be tested?

Outline the steps to test the PR here.

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo Leemoonsoo closed this Jun 17, 2016
@Leemoonsoo Leemoonsoo reopened this Jun 17, 2016
@corneadoug
Copy link
Contributor

@Leemoonsoo Previous errors are gone, nice find

@bzz
Copy link
Member

bzz commented Jun 17, 2016

Looks great to me

@Leemoonsoo
Copy link
Member Author

I'm getting different error ...

Results :

Tests in error: 
  ZeppelinIT.testAngularDisplay:151->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 » Timeout

@Leemoonsoo Leemoonsoo force-pushed the ZEPPELIN-1009 branch 3 times, most recently from c762f7d to fb3e9f6 Compare June 18, 2016 17:13
@Leemoonsoo
Copy link
Member Author

Fixed all error on Zeppelin.java

try { handleException("Debug 1", new RuntimeException()); } catch (Exception e) {};

now getting errors from ParagraphIT

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 88.873 sec - in org.apache.zeppelin.integration.ZeppelinIT

Results :

Tests in error: 
  ParagraphActionsIT.testRemoveButton:149->AbstractZeppelinIT.waitForParagraph:88->AbstractZeppelinIT.pollingWait:114 » Timeout
  ParagraphActionsIT.testMoveUpAndDown:186->AbstractZeppelinIT.waitForParagraph:88->AbstractZeppelinIT.pollingWait:114 » Timeout
  ParagraphActionsIT.testCreateNewButton:80->AbstractZeppelinIT.waitForParagraph:88->AbstractZeppelinIT.pollingWait:114 » Timeout

Tests run: 15, Failures: 0, Errors: 3, Skipped: 0

Here's some experiments about ParagraphIT error,

  • It passes on my local machine with firefox 31.0 (the same version with travis uses)
  • It passes on my travis account, constantly
  • It fails on apache travis account, constantly

And i tried narrow down what cause the error on apache travis account, and in case of ParagraphActionIT.testCreateNewButton, it opens paragraph's setting dropdown menu successfully,

image

And i believe it locates Inserts New button and click(), but nothing happens and test fails.

@bzz
Copy link
Member

bzz commented Jun 20, 2016

Sounds great! Shall we merge this guy then, and handle this nasty click in ParagraphActionIT.testCreateNewButton in separate pr?

@randerzander
Copy link
Contributor

@bzz @Leemoonsoo, you said "i believe it locates Inserts New button and click(), but nothing happens and test fails".

This may be related to https://issues.apache.org/jira/browse/ZEPPELIN-1033. It's not just integration test which fails, the actual functions seem to be broken.

@Leemoonsoo
Copy link
Member Author

@bzz Let me merge this into master and branch-0.6 then
@randerzander Thanks for reporting the problem. yes they might be related!

@asfgit asfgit closed this in 8085ab6 Jun 20, 2016
asfgit pushed a commit that referenced this pull request Jun 20, 2016
### What is this PR for?
Fix selenium test error described in [ZEPPELIN-1009](https://issues.apache.org/jira/browse/ZEPPELIN-1009)

### What type of PR is it?
Hot Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1009

### How should this be tested?
Outline the steps to test the PR here.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1034 from Leemoonsoo/ZEPPELIN-1009 and squashes the following commits:

9a048af [Lee moon soo] restore changes
13e15f1 [Lee moon soo] print browser log
63e8682 [Lee moon soo] sleep
ec03834 [Lee moon soo] try trusty
f05d741 [Lee moon soo] set firefox addon ver
c33d9ff [Lee moon soo] try different xpath
430e273 [Lee moon soo] restore
f145da5 [Lee moon soo] Take some screenshots
b4cab5f [Lee moon soo] Remove debug mesg
1c1b2b8 [Lee moon soo] Increase resolution
b2edf6f [Lee moon soo] change xvfb screen resolution
41d9875 [Lee moon soo] more msg
4d27bf7 [Lee moon soo] More mesg
1dd6e50 [Lee moon soo] add more debug msg
54d58b6 [Lee moon soo] escape quote
fb3e9f6 [Lee moon soo] Add a paragraph infront to prevent main menu cover angular element
667578c [Lee moon soo] add debug messages
da38256 [Lee moon soo] update getParagraphXPath()
55e78ec [Lee moon soo] trigger ci
13dee87 [Lee moon soo] fix

(cherry picked from commit 8085ab6)
Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants