Skip to content

ZEPPELIN-1027: Python - add basic matplotlib example notebook #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bzz wants to merge 1 commit into from
Closed

ZEPPELIN-1027: Python - add basic matplotlib example notebook #1032

bzz wants to merge 1 commit into from

Conversation

@bzz
Copy link
Member

@bzz bzz commented Jun 17, 2016 •
edited
Loading

What is this PR for?

It adds basic python matplotlib example notebook.

What type of PR is it?

Improvement | Documentation

What is the Jira issue?

ZEPPELIN-1027

How should this be tested?

New zeppelin notebook shows up in the list.

Screenshots (if appropriate)

screen shot 2016-06-17 at 14 49 31

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
Copy link
Member Author

bzz commented Jun 17, 2016

I'm planning to add at least one more tutorial notebook of using python, something similar to what we have for Apache Spark but with pandas and matplotlib etc.

Do you guys think advanced one should be incorporated in here - 😕, or shall we have a separate one 😄 , say title "Zeppelin Tutorial: Python - pandas, matplotlib".

@minahlee
Copy link
Member

minahlee commented Jun 17, 2016 •
edited
Loading

I hope we have more example notebooks. Once we have a lot of example notebooks, it won't be efficient to keep all of them embedded in Zeppelin by default. I guess we will manage most of example notebooks on the website in the end. IMO better to separate them by usage so that user can find example notebooks easily on his demand.
And matplotlib example notebook looks good :)

@bzz
Copy link
Member Author

bzz commented Jun 17, 2016 •
edited
Loading

Thank you @minahlee that makes perfect sense to me.

@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Jun 17, 2016

Yeah 👍 for @minahlee. And it looks good! :)

@prabhjyotsingh
Copy link
Contributor

prabhjyotsingh commented Jun 17, 2016

Good one, we should have it. LGTM.

@bzz
Copy link
Member Author

bzz commented Jun 20, 2016 •
edited
Loading

Thank you for prompt reviews!

Merging in master and branch-0.6 if there is no further discussion.

CI fails with node.js dependency install

[INFO] make: Leaving directory `/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/ws/build'
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "install" "--color=false"
[ERROR] npm ERR! node v0.12.13
[ERROR] npm ERR! npm  v2.15.0
[ERROR] 
[ERROR] npm ERR! shasum check failed for /tmp/npm-9969-f242cd1f/registry.npmjs.org/multiparty/-/multiparty-2.2.0.tgz
[ERROR] npm ERR! Expected: a567c2af000ad22dc8f2a653d91978ae1f5316f4
[ERROR] npm ERR! Actual:   50d19b53ff3e86f1a5f2fad8b20ab8bdaeb6d9f5

and Integration tests been taken care of under #1034

@asfgit asfgit closed this in c82dd4e Jun 20, 2016
asfgit pushed a commit that referenced this pull request Jun 20, 2016
@bzz
ZEPPELIN-1027: Python - add basic matplotlib example notebook
b0d9917 
### What is this PR for?
It adds basic [python matplotlib example notebook](https://www.zeppelinhub.com/viewer/notebooks/aHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL2J6ei9pbmN1YmF0b3ItemVwcGVsaW4vMTkyZjU3YjZjMGZkMjc4NzgwZDI3NDAzMGY1YmJlOTZlZThkNzdiYi9ub3RlYm9vay8yQlFBMzVDSlovbm90ZS5qc29u).

### What type of PR is it?
Improvement | Documentation

### What is the Jira issue?
[ZEPPELIN-1027](https://issues.apache.org/jira/browse/ZEPPELIN-1027)

### How should this be tested?
New [zeppelin notebook](https://www.zeppelinhub.com/viewer/notebooks/aHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL2J6ei9pbmN1YmF0b3ItemVwcGVsaW4vMTkyZjU3YjZjMGZkMjc4NzgwZDI3NDAzMGY1YmJlOTZlZThkNzdiYi9ub3RlYm9vay8yQlFBMzVDSlovbm90ZS5qc29u) shows up in the list.

### Screenshots (if appropriate)
![screen shot 2016-06-17 at 14 49 31](https://cloud.githubusercontent.com/assets/5582506/16141850/bc0c70b0-349a-11e6-81d1-98d8b1d2af4c.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Alexander Bezzubov <[email protected]>

Closes #1032 from bzz/python/add-example-notebook and squashes the following commits:

192f57b [Alexander Bezzubov] Python: add basic matplotlib example notebook

(cherry picked from commit c82dd4e)
Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz bzz deleted the python/add-example-notebook branch June 20, 2016 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bzz @minahlee @AhyoungRyu @prabhjyotsingh