[ZEPPPELIN-1009] Trying to Fix selenium modal error

[corneadoug]

What is this PR for?

This is to check Selenium test failing on Master and #979

What type of PR is it?

Flacky test fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1009

Questions:

• Does the licenses files need update? No
• Is there breaking changes for older versions? No
• Does this needs documentation? No

[bzz]

Two CI failures here

1. Python test failure

logs AFAIK never seen before (might be related to #1009)

Running org.apache.zeppelin.python.PythonInterpreterTest
org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest)  Time elapsed: 0.436 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:170)

Failed tests: 
PythonInterpreterTest.testClose:170 null

Tests run: 5, Failures: 1, Errors: 0, Skipped: 0

2. Integration Tests failure

Logs

Tests in error: 
ZeppelinIT.testSparkInterpreterDependencyLoading:214->AbstractZeppelinIT.createNewNote:133 » Timeout
ParagraphActionsIT.testRemoveButton:165 » NoSuchElement Unable to locate eleme...
ParagraphActionsIT.testCreateNewButton:92 » NoSuchElement Unable to locate ele...

Tests run: 14, Failures: 0, Errors: 3, Skipped: 0

[bzz]

@corneadoug as a first step, how about re-open the PR to trigger CI and see, which ones are reproducible by posting same report for new CI build results?

[corneadoug]

Only both errors about delete button are there after running the CI again

[corneadoug]

No problem running the test locally

[bzz]

on #1021 in logs I can see

ParagraphActionsIT.testRemoveButton

org.apache.zeppelin.integration.ParagraphActionsIT.testRemoveButton(ParagraphActionsIT.java:152)
03:13:23,791  INFO org.apache.zeppelin.AbstractZeppelinIT:59 - Finished.
03:13:53,820 ERROR org.apache.zeppelin.AbstractZeppelinIT:153 - Exception in ParagraphActionsIT while testRemoveButton 
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@class='modal-dialog'][contains(.,'delete this paragraph')]//div[@class='modal-footer']//button[contains(.,'OK')]"}
Command duration or timeout: 30.03 seconds

when the browser gets trapped in this state, as one can see - there is indeed no modal dialog on the screen

So may be its previous line, //ul/li/a[@ng-click='removeParagraph()'] that fails to trigger paragrpah removal here?

[corneadoug]

@bzz where did you get the screenshot from?

The modal is supposed to show, I modified the test in this PR to have a check on that, and current scenario looks like this:

• Find the paragraph icon-setting and click on it
• Find the remove paragraph button and click on it
• Does Modal Exist? -> True
• Find the Modal Ok button and Click on It -> failed

[bzz]

@corneadoug sounds good! Screenshot is in the logs in base64.
Could you post current CI failure in the same way as I did above? Then we could iterate faster on it

[corneadoug]

@bzz Do you know in which case it takes a screenshot?
I see this in the log before the screenshot

09:14:21,371 ERROR org.apache.zeppelin.AbstractZeppelinIT:155 - ScreenShot::

However, the log place the error at line 166
cf:

Tests in error: 
  ParagraphActionsIT.testRemoveButton:166 » NoSuchElement Unable to locate eleme...
  ParagraphActionsIT.testCreateNewButton:92 » NoSuchElement Unable to locate ele...

09:11:54,159  INFO org.apache.zeppelin.AbstractZeppelinIT:51 - Caller: org.apache.zeppelin.integration.ParagraphActionsIT.testRemoveButton(ParagraphActionsIT.java:158)
09:11:55,160  INFO org.apache.zeppelin.AbstractZeppelinIT:59 - Finished.
09:12:55,241 ERROR org.apache.zeppelin.AbstractZeppelinIT:153 - Exception in ParagraphActionsIT while testRemoveButton 
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@class='bootstrap-dialog-footer']//button[contains(text() ,'OK')]"}
Command duration or timeout: 30.07 seconds

[Leemoonsoo]

handleException() take screenshot. ParagraphActionIT catches all exceptions during test and call handleException() to screenshot.

To take screenshot manually, Insert following line where you want,

try { handleException("ANY MSG", new RuntimeException();} catch (Exception e) {};

I was working on #1034, it does not fix all the selenium error, but it fixes all errors on ZeppelinIT.
Please take a look and feel free to merge #1034.

[corneadoug]

@Leemoonsoo Yes we will go with your PR, so I will close this one