Skip to content

Python interpreter and doc cleanup #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bzz wants to merge 6 commits into from
Closed

Python interpreter and doc cleanup #1021

bzz wants to merge 6 commits into from

Conversation

@bzz
Copy link
Member

@bzz bzz commented Jun 16, 2016

What is this PR for?

This is first step improving current Python interpreter implementation.
It has just a cleanup, style and docs improvements.

What type of PR is it?

Improvement

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
Copy link
Member Author

bzz commented Jun 16, 2016

CI failure is not related and is taken care of under #1015

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.3 sec - in org.apache.zeppelin.integration.SparkParagraphIT

Results :

Tests in error: 
  ParagraphActionsIT.testRemoveButton:153 » NoSuchElement Unable to locate eleme...
  ParagraphActionsIT.testCreateNewButton:86 » NoSuchElement Unable to locate ele...

Tests run: 14, Failures: 0, Errors: 2, Skipped: 0

Ready to be merged to master now.

@felixcheung
Copy link
Member

felixcheung commented Jun 16, 2016

LGTM

@AhyoungRyu
Copy link
Contributor

AhyoungRyu commented Jun 16, 2016

LGTM 👍

@astroshim
Copy link
Contributor

astroshim commented Jun 16, 2016

LGTM

1 similar comment
@prabhjyotsingh
Copy link
Contributor

prabhjyotsingh commented Jun 16, 2016

LGTM

@bzz
Copy link
Member Author

bzz commented Jun 16, 2016

Thank you for prompt reviews!

Merging if there is no more discussion.

@bzz bzz mentioned this pull request Jun 16, 2016
Closed
@asfgit asfgit closed this in c806d4a Jun 17, 2016
@bzz bzz deleted the improve/python branch June 20, 2016 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bzz @felixcheung @AhyoungRyu @astroshim @prabhjyotsingh