[CodeGenC] Use PrimFuncNode::ret_type in function signature #15073
+28
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, the return type for `CodeGenC` was hard-coded as part of `virtual CodeGenC::PrintFuncPrefix`, regardless of the return type specified in the `PrimFunc`. This PR updates `CodeGenC` to use `PrimFuncNode::ret_type` for the return type in the generated C code. This change should have no effect on observable behavior. The majority of codegen classes specified a `void` return type, which matches the default `DataType::Void()` for a `PrimFunc`. The one exception is `CodeGenCHost::PrintFuncPrefix`, which specified an `int32_t` return type, matching the `DataType::Int(32)` used for the functions generated by `MakePackedAPI` and `MakeUnpackedAPI`.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 12, 2023
Previously, the return value of a PackedFunc was hard-coded as the string `"return 0;"` in `CodeGenCHost`, which could cause compilation errors for `PrimFunc` returning `DataType::Void()`. This PR removes this explicit return statement from `CodeGenCHost`, replacing it with `tir::ret(Integer(0))` in the `MakePackedAPI` and `MakeUnpackedAPI` transforms. This is related to apache#15073, which performs an analogous change for the function signature.
tqchen
approved these changes
Jun 13, 2023
csullivan
pushed a commit
that referenced
this pull request
Jun 15, 2023
* [TIR][CodeGen] Define PackedFunc error code in MakePackedAPI Previously, the return value of a PackedFunc was hard-coded as the string `"return 0;"` in `CodeGenCHost`, which could cause compilation errors for `PrimFunc` returning `DataType::Void()`. This PR removes this explicit return statement from `CodeGenCHost`, replacing it with `tir::ret(Integer(0))` in the `MakePackedAPI` and `MakeUnpackedAPI` transforms. This is related to #15073, which performs an analogous change for the function signature. * Handle builtin::ret() in CodeGenC * Place T.ret(0) inside asserts, rather than outside This causes fewer unit tests to break, and has more readable TVMScript. * Update unit tests to look inside SeqStmt * Handle T.ret(0) in CodeGenStackVM * Update MakeUnpackedAPI tests to expect T.ret
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jun 22, 2023
…5073) Prior to this PR, the return type for `CodeGenC` was hard-coded as part of `virtual CodeGenC::PrintFuncPrefix`, regardless of the return type specified in the `PrimFunc`. This PR updates `CodeGenC` to use `PrimFuncNode::ret_type` for the return type in the generated C code. This change should have no effect on observable behavior. The majority of codegen classes specified a `void` return type, which matches the default `DataType::Void()` for a `PrimFunc`. The one exception is `CodeGenCHost::PrintFuncPrefix`, which specified an `int32_t` return type, matching the `DataType::Int(32)` used for the functions generated by `MakePackedAPI` and `MakeUnpackedAPI`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the return type for
CodeGenCwas hard-coded as part ofvirtual CodeGenC::PrintFuncPrefix, regardless of the return type specified in thePrimFunc. This PR updatesCodeGenCto usePrimFuncNode::ret_typefor the return type in the generated C code.This change should have no effect on observable behavior, while allowing the forward declaration of external functions to be improved. The majority of codegen classes specified a
voidreturn type, which matches the defaultDataType::Void()for aPrimFunc. The one exception isCodeGenCHost::PrintFuncPrefix, which specified anint32_treturn type, matching theDataType::Int(32)used for the functions generated byMakePackedAPIandMakeUnpackedAPI.