Skip to content

Conversation

@Lunderberg
Copy link
Contributor

Part of changes being split out from #14778 into independent portions. This commit allows TIR cache_read and cache_write schedule primitives to preserve DeclBuffer nodes.

Part of changes being split out from
apache#14778 into independent portions.
This commit allows TIR `cache_read` and `cache_write` schedule
primitives to preserve `DeclBuffer` nodes.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@vinx13 vinx13 merged commit dcf1b1a into apache:main Jun 16, 2023
@Lunderberg Lunderberg deleted the declbuffer_tir_schedule_cache_read_write branch June 17, 2023 01:24
@tqchen
Copy link
Member

tqchen commented Jun 17, 2023

@Lunderberg there seems to be a regression introduced by this PR

@Lunderberg
Copy link
Contributor Author

@tqchen Is there a specific test case for the regression? I pulled the latest main (31be726) and re-ran the tests introduced by this PR, and they are currently passing.

@tqchen
Copy link
Member

tqchen commented Jun 20, 2023

@tqchen
Copy link
Member

tqchen commented Jun 20, 2023

Not sure if it is a failed or flaky test, it is something that appears in this PR, and some followup commits. Perhaps some recent changes introduces some non-determinsm?

@Lunderberg
Copy link
Contributor Author

Thank you, and I can reproduce that failure. It does seem to be a flaky test, with 28 failures out of 100 repetitions on main.

Though, on bisecting, it looks like the flaky failures were introduced in 02dc191 (#15081). The previous commit, 68ac909 (#15073), is able to pass the test 100/100 times, while #15081 shows about the same 30% failure rate.

@Lunderberg
Copy link
Contributor Author

I have a quick bugfix PR at #15128, which should resolve the flaky test. I didn't tracked down why that specific overwrite results in failure to recognize a stage pipeline, but that does resolve the specific failure mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants