[TIR][CodeGen] Define PackedFunc error code in MakePackedAPI #15076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the return value of a PackedFunc was hard-coded as the string `"return 0;"` in `CodeGenCHost`, which could cause compilation errors for `PrimFunc` returning `DataType::Void()`. This PR removes this explicit return statement from `CodeGenCHost`, replacing it with `tir::ret(Integer(0))` in the `MakePackedAPI` and `MakeUnpackedAPI` transforms. This is related to apache#15073, which performs an analogous change for the function signature.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
This causes fewer unit tests to break, and has more readable TVMScript.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 13, 2023
Previously, some operations in `tvm.tir.op` required the operand to already be a `PrimExpr`, and raised an error if the operand was instead a python object. This could cause failures round-trip through TVMScript, as int32 and float32 types are printed as literals in TVMScript, relying on automatic conversion to convert them back into `PrimExpr` objects. For example, `T.expr2(T.int32(0))` is printed as `T.expr2(0)`, which then passes the python object `0` into `tvm.tir.op.expr2` when parsing the TVMScript. This commit updates the operations in `tvm.tir.op` to convert operands prior to accessing `operand.dtype`, avoiding the error and allowing these expressions to round-trip. This issue was first noticed in apache#15076 for `T.ret(0)`, but applied to any operator that used the operand's dtype without first normalizing to `PrimExpr`.
csullivan
approved these changes
Jun 15, 2023
csullivan
pushed a commit
that referenced
this pull request
Jun 15, 2023
Previously, some operations in `tvm.tir.op` required the operand to already be a `PrimExpr`, and raised an error if the operand was instead a python object. This could cause failures round-trip through TVMScript, as int32 and float32 types are printed as literals in TVMScript, relying on automatic conversion to convert them back into `PrimExpr` objects. For example, `T.expr2(T.int32(0))` is printed as `T.expr2(0)`, which then passes the python object `0` into `tvm.tir.op.expr2` when parsing the TVMScript. This commit updates the operations in `tvm.tir.op` to convert operands prior to accessing `operand.dtype`, avoiding the error and allowing these expressions to round-trip. This issue was first noticed in #15076 for `T.ret(0)`, but applied to any operator that used the operand's dtype without first normalizing to `PrimExpr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the return value of a PackedFunc was hard-coded as the string
"return 0;"inCodeGenCHost, which could cause compilation errors forPrimFuncreturningDataType::Void(). This PR removes this explicit return statement fromCodeGenCHost, replacing it withtir::ret(Integer(0))in theMakePackedAPIandMakeUnpackedAPItransforms.This is related to #15073, which performs an analogous change for the function signature.