[ARITH] Improve arith simplify to handle symbolic reshape pattern #15081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enhances arith simplify to handle symbolic reshape patterns. Lift the CombineIters to callers of TryFuseIters so they can be used in early return simplifications. Testcases are added. Also updates a minor spelling issue in the testcase.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
MasterJH5574
approved these changes
Jun 13, 2023
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jun 20, 2023
This commit resolves a flaky test failure that was introduced in apache#15081. The unit test `tests/python/unittest/test_meta_schedule_schedule_rule_mlt_tc.py::test_padded_matmul_relu` failed approximately 30% of the time. The error was due to changes in `IterMapRewriter::NormalizeToIterWithOffset`. When attempting a simplfication with `TryCombineSplitFromSameSource`, if the returned `Optional<IterSumExpr>` is defined, but the `args.size() < 1` check fails, then the `expr` argument is still overwritten, and presumably can cause a later `TryFuseIters(expr)` to fail. This commit replaces `expr = opt.value();` with `auto combined = opt.value();`, preserving the original argument.
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jun 22, 2023
…ache#15081) This PR enhances arith simplify to handle symbolic reshape patterns. Lift the CombineIters to callers of TryFuseIters so they can be used in early return simplifications. Testcases are added. Also updates a minor spelling issue in the testcase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances arith simplify to handle symbolic reshape patterns. Lift the CombineIters to callers of TryFuseIters so they can be used in early return simplifications. Testcases are added.
Also updates a minor spelling issue in the testcase.