Skip to content

Conversation

@graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Apr 9, 2019

SUMMARY

db migration in #6945 was based on an older head. I run superset db merge heads to make it compatible with master, but when we run superset db upgrade, somehow downgrade script from #6945 is not triggered.

Solution:
Now I rebased migration script to latest master to make sure revision is from latest master. So downgrade script will be executed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN

run superset db upgrade should see extra parents attribute in layout meta data.
run superset db downgrade should see parents attribute are removed.

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[ ] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@michellethomas @john-bodley

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #7258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7258   +/-   ##
=======================================
  Coverage   64.72%   64.72%           
=======================================
  Files         425      425           
  Lines       20672    20672           
  Branches     2282     2282           
=======================================
  Hits        13380    13380           
  Misses       7167     7167           
  Partials      125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50e6bc...4087f4d. Read the comment docs.

# revision identifiers, used by Alembic.
revision = '80669c0097a6'
down_revision = 'c82ee8a39623'
revision = '80aa3f04bc82'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should keep the revision ID unchanged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after rebase, I created script from scratch, so the system generated new file name.

@graceguo-supercat
Copy link
Author

thanks! i will test in local environment right after merge.

@graceguo-supercat graceguo-supercat merged commit 1104aca into apache:master Apr 10, 2019
@graceguo-supercat graceguo-supercat deleted the gg-FixMigrationRevision branch June 11, 2020 23:21
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants