[fix] Update migration Revision for #6945 #7258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
db migration in #6945 was based on an older head. I run
superset db merge headsto make it compatible with master, but when we runsuperset db upgrade, somehow downgrade script from #6945 is not triggered.Solution:
Now I rebased migration script to latest master to make sure revision is from latest master. So downgrade script will be executed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
run
superset db upgradeshould see extra parents attribute in layout meta data.run
superset db downgradeshould see parents attribute are removed.ADDITIONAL INFORMATION
REVIEWERS
@michellethomas @john-bodley