Skip to content

Conversation

@graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 26, 2019

This migration is to add parent ids for each UI element in dashboard layout metadata. This will be used by another feature (#6964): to provide a redirect link that can open dashboard in any tab.

Expected output:
screen shot 2019-03-01 at 3 14 32 pm

We store dashboard layout metadata in a flatted tree structure. In old layout metadata, we only store children node for each UI component. This information is good enough for render dashboard from root element, and we always render first tab when dashboard opens. But If user want to see some information in other tab (or any chart in a nested tab), it will takes a few clicks to navigate to the point of interest.

This problem can be resolved if each UI component carries its parent node information. When we have parents list for each UI component, it's easy from dashboard root to render each parent id, and at last render the point of interest chart/tab.

Because this db migration is independent of UI change (do not block dashboard display), I will send out UI change in a different PR.

@john-bodley @michellethomas @kristw @williaster

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #6945 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6945   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files         422      422           
  Lines       20595    20595           
  Branches     2253     2253           
=======================================
  Hits        13311    13311           
  Misses       7161     7161           
  Partials      123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e767e4d...9e0636a. Read the comment docs.

@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community risk:db-migration PRs that require a DB migration labels Mar 4, 2019
@graceguo-supercat graceguo-supercat force-pushed the gg-AddParentsInDashboardLayout branch 2 times, most recently from 10b0426 to 3659891 Compare March 8, 2019 00:51
@graceguo-supercat graceguo-supercat force-pushed the gg-AddParentsInDashboardLayout branch 2 times, most recently from 9f5d94f to 0fa9834 Compare March 20, 2019 17:24
@graceguo-supercat graceguo-supercat force-pushed the gg-AddParentsInDashboardLayout branch from 0fa9834 to 9e0636a Compare April 4, 2019 20:24
@graceguo-supercat graceguo-supercat merged commit 139f299 into apache:master Apr 9, 2019
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Apr 9, 2019
graceguo-supercat pushed a commit that referenced this pull request Apr 10, 2019
@graceguo-supercat graceguo-supercat deleted the gg-AddParentsInDashboardLayout branch July 19, 2019 19:17
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community risk:db-migration PRs that require a DB migration 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants