Skip to content

[fix] Update migration Revision for #6945 #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graceguo-supercat merged 1 commit into from
Apr 10, 2019
Merged

[fix] Update migration Revision for #6945 #7258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...7a6_add_parent_ids_in_dashboard_layout.py → ...c82_add_parent_ids_in_dashboard_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
# under the License.
"""Add Parent ids in dashboard layout metadata

Revision ID: 80669c0097a6
Revises: c82ee8a39623
Create Date: 2019-02-25 15:43:02.488328
Revision ID: 80aa3f04bc82
Revises: 45e7da7cfeba
Create Date: 2019-04-09 16:27:03.392872

"""
import json
Expand All @@ -38,8 +38,8 @@
from superset import db

# revision identifiers, used by Alembic.
revision = '80669c0097a6'
down_revision = 'c82ee8a39623'
revision = '80aa3f04bc82'
Copy link
Member

@john-bodley john-bodley Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should keep the revision ID unchanged.

Copy link
Author

@graceguo-supercat graceguo-supercat Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after rebase, I created script from scratch, so the system generated new file name.

down_revision = '45e7da7cfeba'

Base = declarative_base()

Expand Down
38 changes: 0 additions & 38 deletions superset/migrations/versions/c8beba38d316_.py
View file
Open in desktop

This file was deleted.