fix(webpack): skip building service worker in dev

[msyavuz]

SUMMARY

#36191 Introduced a service-worker file and the build output file in static directory. With this pr we ignore it in development mode to prevent webpack creating a build file everytime and prevents accidental committing of that generated file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1. Run webpack dev server with npm run dev-server
2. New service-worker.js file should not be created

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #eb8a6a

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 99f2b3b..99f2b3b

  • superset-frontend/webpack.config.js
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

Sequence Diagram

Shows the change where the webpack configuration conditionally excludes the service-worker entry in development, so the dev server does not generate/overwrite the service-worker output file. This prevents accidental commits of generated files during development.

sequenceDiagram
    participant Dev as Developer / Dev Server
    participant Webpack as Webpack (config)
    participant Build as Build Output (static/)
    
    Dev->>Webpack: start dev-server (isDevMode = true)
    Webpack->>Webpack: evaluate entries (service-worker only added if not dev)
    alt Dev mode
        Webpack-->>Build: build without service-worker (no service-worker.js created)
    else Prod mode
        Webpack-->>Build: build including service-worker (service-worker.js generated)
    end

Loading

---

Generated by CodeAnt AI

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it