Skip to content

fix(webpack): skip building service worker in dev #38106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyavuz merged 2 commits into from
Feb 19, 2026
Merged

fix(webpack): skip building service worker in dev #38106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f2b3b
fix(webpack): skip building service worker in dev
msyavuz Feb 19, 2026
ac1758f
fix: ci
msyavuz Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion superset-frontend/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,10 @@ const config = {
menu: addPreamble('src/views/menu.tsx'),
spa: addPreamble('src/views/index.tsx'),
embedded: addPreamble('src/embedded/index.tsx'),
'service-worker': path.join(APP_DIR, 'src/service-worker.ts'),
// Skip service-worker build in dev mode to avoid overwriting the placeholder
...(isDevMode ? {} : {
'service-worker': path.join(APP_DIR, 'src/service-worker.ts'),
}),
Comment thread
rusackas marked this conversation as resolved.
Outdated
},
cache: {
type: 'filesystem',
Expand Down
Loading