feat: Add PWA file handler for CSV/XLS/Parquet uploads

[betodealmeida]

User description

SUMMARY

Make Superset a progressive web app (PWA) by adding a manifest file.

Also add functionality to allow CSV/XLS/Parquet file uploads from the desktop.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

CodeAnt-AI Description

Add PWA install and desktop file-handler for CSV/Excel/Parquet

What Changed

• Superset can be installed as a Progressive Web App (PWA): a manifest and service worker are registered so users can install the app and see install screenshots and icons.
• Desktop file handling: opening CSV, .xls/.xlsx, or Parquet files from the OS launches Superset and opens the upload modal populated with the selected file so users can import directly.
• Unsupported or failed file launches show a clear error toast and redirect users back to the welcome page; closing the upload modal also returns users to the welcome page.
• Browser support and scope: service worker is emitted at the root, and responses include a header allowing the service worker to control the root scope to enable file-handler registration.
• Automated tests added to verify file-handler behaviors (CSV/Excel/Parquet handling, error cases, redirects, and loading state).

Impact

✅ Installable desktop app via browser PWA prompt
✅ Open CSV/Excel/Parquet files from desktop into Superset upload flow
✅ Clearer errors and consistent redirect when file handling fails or is unsupported

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[codeant-ai-for-open-source]

💡 Enhance Your PR Reviews

We noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow:

🚦 Quality Gates

Status: Quality Gates are not enabled at the organization level
Learn more about Quality Gates

🎫 Jira Ticket Compliance

Status: Jira credentials file not found. Please configure Jira integration in your settings
Learn more about Jira Integration

⚙️ Custom Rules

Status: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository
Learn more about Custom Rules

---

Want to enable these features? Contact your organization admin or check our documentation for setup instructions.

[rusackas]

LGTM! Not sure if SVG is supported, but that'd be neat to not require more flavors of logo file.

Not sure if the the screenshot image can just link to the one(s) from the readme/docs, but the goal is to automate those so they're always current, in the near future.

Barring the above, rebase and go for it!

[bito-code-review]

Code Review Agent Run #693f87

Actionable Suggestions - 0

Additional Suggestions - 3

• superset-frontend/src/features/databases/UploadDataModel/index.tsx - 1

  • useEffect inefficiency · Line 530-544
    The useEffect depends on previewUploadedFile but only uses it conditionally, potentially causing unnecessary re-runs. Also, the loadFileMetadata promise lacks error handling.
    Code suggestion

     @@ -530,15 +530,18 @@
    -  useEffect(() => {
    -    if (fileListOverride?.length) {
    -      setFileList(
    -        fileListOverride.map(file => ({
    -          uid: file.name,
    -          name: file.name,
    -          originFileObj: file as UploadFile['originFileObj'],
    -          status: 'done' as const,
    -        })),
    -      );
    -      if (previewUploadedFile) {
    -        loadFileMetadata(fileListOverride[0]).then(r => r);
    -      }
    -    }
    -  }, [fileListOverride, previewUploadedFile]);
    +  useEffect(() => {
    +    if (fileListOverride?.length) {
    +      setFileList(
    +        fileListOverride.map(file => ({
    -          uid: file.name,
    -          name: file.name,
    -          originFileObj: file as UploadFile['originFileObj'],
    -          status: 'done' as const,
    -        })),
    -      );
    -      if (previewUploadedFile) {
    -        loadFileMetadata(fileListOverride[0]).catch(error => {
    -          addDangerToast(error.error || 'Error');
    -        });
    -      }
    -    } else {
    -      setFileList([]);
    -    }
    -  }, [fileListOverride, previewUploadedFile]);

• superset/static/service-worker.js - 1

  • Misleading Comment · Line 20-20
    The comment claims 'PWA file handling support', but the service worker only handles install and activate events without any file-related logic like fetch interception.
• superset/templates/superset/spa.html - 1

  • PWA Feature Compatibility · Line 33-35
    The PWA manifest includes file_handlers, an experimental feature with limited browser support (primarily Chromium-based browsers with flags enabled). This may not work for Firefox or Safari users, potentially leading to confusion if file handling is expected. Consider removing it for broader compatibility, or document the limitation.

Review Details

• Files reviewed - 10 · Commit Range: c9c22e5..d1c1a7d

  • superset-frontend/src/features/databases/UploadDataModel/index.tsx
  • superset-frontend/src/pages/FileHandler/index.test.tsx
  • superset-frontend/src/pages/FileHandler/index.tsx
  • superset-frontend/src/service-worker.ts
  • superset-frontend/src/views/routes.tsx
  • superset-frontend/webpack.config.js
  • superset/initialization/__init__.py
  • superset/static/service-worker.js
  • superset/templates/superset/spa.html
  • superset/views/core.py
• Files skipped - 1

  • superset-frontend/src/pwa-manifest.json - Reason: Filter setting
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

Suggestion: The file type detection logic only recognizes .csv, .xls, .xlsx, and .parquet extensions, ignoring other formats that the existing upload modal already supports (notably .tsv for delimited text and .zip for columnar uploads). This causes a valid TSV or zipped columnar file that can be uploaded via the standard UI to be rejected as "Unsupported file type" when opened via the PWA file handler, leading to inconsistent behavior between entry points. [logic error]

Severity Level: Major ⚠️

- ❌ PWA file-launch rejects .tsv desktop uploads.
- ❌ PWA file-launch rejects zipped columnar (.zip) uploads.
- ⚠️ Inconsistent behavior vs UploadDataModal (upload UI).
- ⚠️ User-facing redirect to welcome page on open.

Suggested change

	let type: 'csv' | 'excel' | 'columnar' | null = null;
	let extensions: string[] = [];
	if (fileName.endsWith('.csv')) {
	type = 'csv';
	extensions = ['csv'];
	} else if (fileName.endsWith('.xls') || fileName.endsWith('.xlsx')) {
	type = 'excel';
	extensions = ['xls', 'xlsx'];
	} else if (fileName.endsWith('.parquet')) {
	type = 'columnar';
	extensions = ['parquet'];
	const extension = fileName.split('.').pop() || '';
	let type: 'csv' | 'excel' | 'columnar' | null = null;
	let extensions: string[] = [];
	if (extension === 'csv' || extension === 'tsv') {
	type = 'csv';
	// Match the CSV behavior in UploadDataModal (supports csv and tsv)
	extensions = ['csv', 'tsv'];
	} else if (extension === 'xls' || extension === 'xlsx') {
	type = 'excel';
	extensions = ['xls', 'xlsx'];
	} else if (extension === 'parquet' || extension === 'zip') {
	// Columnar uploads also support zipped files
	type = 'columnar';
	extensions = ['parquet', 'zip'];

Steps of Reproduction ✅

1. Navigate to the PWA file-handler route (the component is mounted at
/superset/file-handler and defined in superset-frontend/src/pages/FileHandler/index.tsx).
The launchQueue consumer is registered in useEffect at lines 52-112, specifically
launchQueue.setConsumer(...) at lines 66-108.

2. From the desktop, open a supported-but-unchecked file type (example: a tab-separated
file test.tsv or a zipped columnar file test.zip). The OS will invoke the PWA and the
LaunchQueue consumer receives the file handle; the consumer callback receives launchParams
and executes the code starting at line 73 (const fileHandle = launchParams.files[0];).

3. FileHandler reads the File object via fileHandle.getFile() (line 74) and computes
fileName at line 75. The current logic checks
fileName.endsWith('.csv'/.xls/.xlsx/.parquet) (lines 80-88) and will not match '.tsv' or
'.zip'.

4. Because '.tsv' and '.zip' are not recognized, the else branch at lines 89-97 runs: a
danger toast is added with the message 'Unsupported file type...' and the user is
redirected to '/superset/welcome/' (lines 90-96). The upload modal is never opened.

5. Contrast with the existing UploadDataModal behavior: allowedExtensionsToAccept includes
'.tsv' for csv and '.zip' for columnar at src/features/databases/UploadDataModel/index.tsx
lines 166-170, and validateUploadFileExtension (lines 178-192) accepts those extensions.
This shows the FileHandler rejection is inconsistent with the modal's supported
extensions.

6. Reproduced in tests: the component tests in
superset-frontend/src/pages/FileHandler/index.test.tsx simulate launchQueue file handles
and expect the modal to open for various extensions (see tests for csv/xls/xlsx/parquet).
Adding a test case for 'test.tsv' or 'test.zip' will fail with the current FileHandler
logic (it will trigger the unsupported-file branch).

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** superset-frontend/src/pages/FileHandler/index.tsx
**Line:** 76:88
**Comment:**
	*Logic Error: The file type detection logic only recognizes `.csv`, `.xls`, `.xlsx`, and `.parquet` extensions, ignoring other formats that the existing upload modal already supports (notably `.tsv` for delimited text and `.zip` for columnar uploads). This causes a valid TSV or zipped columnar file that can be uploaded via the standard UI to be rejected as "Unsupported file type" when opened via the PWA file handler, leading to inconsistent behavior between entry points.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	376aecc
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6980c9403faf960008af99e1
😎 Deploy Preview	https://deploy-preview-36191--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it