Skip to content

fix(list roles): dont send invalid querystrings #33060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geido merged 1 commit into from
Apr 9, 2025
Merged

fix(list roles): dont send invalid querystrings #33060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-frontend/src/pages/RolesList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function RolesList({ addDangerToast, addSuccessToast, user }: RolesListProps) {

const fetchPage = async (pageIndex: number) => {
const response = await SupersetClient.get({
endpoint: `api/v1/security/permissions-resources/?q={"page_size":${pageSize}, "page":${pageIndex}}`,
endpoint: `api/v1/security/permissions-resources/?q=(page_size:${pageSize},page:${pageIndex})`,
});

return {
Expand Down Expand Up @@ -163,7 +163,7 @@ function RolesList({ addDangerToast, addSuccessToast, user }: RolesListProps) {

const fetchPage = async (pageIndex: number) => {
const response = await SupersetClient.get({
endpoint: `api/v1/security/users/?q={"page_size":${pageSize},"page":${pageIndex}}`,
endpoint: `api/v1/security/users/?q=(page_size:${pageSize},page:${pageIndex})`,
});
return response.json;
};
Comment on lines 164 to 169

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

@landryb landryb Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm pretty sure the above automated review feedback also applied to the previously existing code, so i'm not going to take it into account...

Expand Down
Loading